ci: add syntax/install gates and advisory lint workflow#1
Open
reversesingularity wants to merge 2 commits into
Open
ci: add syntax/install gates and advisory lint workflow#1reversesingularity wants to merge 2 commits into
reversesingularity wants to merge 2 commits into
Conversation
Also fixes the space in 'class EarthquakeL STM' in the orphaned app/ml/lstm_model.py (imported by nothing; could never parse) so the compileall gate passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first code-quality CI to this repository (existing workflows are scheduled data jobs only). Deliberately zero-runtime-risk: no application behavior changes.
Changes
.github/workflows/ci.ymlon ubuntu with two hard gates —python -m compileall app(syntax) anduv pip install -e .(dependency resolvability) — plus two advisory steps (ruff check,pytest --collect-only) markedcontinue-on-erroruntil the lint baseline is cleaned and the PostgreSQL-backed test suite (pytest-postgresql) gets service wiring.app/ml/lstm_model.py:class EarthquakeL STM:→class EarthquakeLSTM:. The file is orphaned (grep: nothing imports it) and could never be parsed, so this cannot change runtime behavior — it exists solely so the syntax gate can be a hard gate.Verification
python -m compileall -q backend/app— green locally after the fix (previously failed on the syntax error).Risk
Minimal — CI plus a syntax repair in dead code. The live Railway deployment is untouched.
Rollback
Revert the merge commit.