Skip to content

fix: allow npm install without changing yarn-first workflow#1229

Open
JackWilb wants to merge 10 commits into
devfrom
npm-install-compat-pr-1779068096
Open

fix: allow npm install without changing yarn-first workflow#1229
JackWilb wants to merge 10 commits into
devfrom
npm-install-compat-pr-1779068096

Conversation

@JackWilb
Copy link
Copy Markdown
Contributor

@JackWilb JackWilb commented May 18, 2026

Closes #1218

Summary

Allow habitual npm install users to install dependencies without changing the project's Yarn-first workflow.

Changes

  • package.json: remove the Yarn-only preinstall guard that hard-failed npm installs.
  • package.json: align lint dependencies for npm peer resolution by downgrading eslint to ^8.57.1 and eslint-plugin-react-hooks to ^4.6.2 while keeping the Airbnb-based lint setup intact.
  • package.json: update @visdesignlab/upset2-react to ^1.2.4, react-vega to ^8.0.0, and vega-lite to ^6.0.1 so strict npm peer resolution succeeds.
  • yarn.lock: refresh the Yarn lockfile to reflect the dependency updates.
  • package-lock.json: add an npm lockfile generated from the updated dependency graph.

Validation

  • yarn install --mode=skip-build
  • npm install --package-lock-only --ignore-scripts
  • yarn typecheck (currently fails on pre-existing errors in src/store/hooks/tests/usePreviousStep.spec.ts)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Starting deployment of preview ⏳...

@JackWilb
Copy link
Copy Markdown
Contributor Author

@copilot remove p_DO_NOT_USE_NPM_USE_YARN and fix Run yarn lint
yarn run v1.22.22
$ eslint src

/home/runner/work/study/study/src/analysis/individualStudy/summary/utils.tsx
Error: 156:3 error Default parameters should be last default-param-last

/home/runner/work/study/study/src/components/audioAnalysis/AudioProvenanceVis.tsx
Error: 233:12 error Unexpected constant condition no-constant-condition

/home/runner/work/study/study/src/components/audioAnalysis/useUpdateProvenance.tsx
Error: 43:12 error Unexpected constant condition no-constant-condition

/home/runner/work/study/study/src/controllers/VegaController.tsx
Error: 6:27 error Unable to resolve path to module 'react-vega/lib/Vega' import/no-unresolved

/home/runner/work/study/study/src/parser/types.ts
Error: 5:41 error 'JsonObject' was used before it was defined no-use-before-define
Error: 5:54 error 'JsonArray' was used before it was defined no-use-before-define

/home/runner/work/study/study/src/store/store.tsx
Error: 27:3 error Default parameters should be last default-param-last

✖ 7 problems (7 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 18, 2026

@copilot remove p_DO_NOT_USE_NPM_USE_YARN and fix Run yarn lint
yarn run v1.22.22
$ eslint src
...

Implemented and pushed the requested lint fixes and cleanup in commit 17cee29 (plus prior related fix commit 6fc6332). p_DO_NOT_USE_NPM_USE_YARN is not present anymore, and yarn lint now passes locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants