Skip to content

♻️ refactor: Newtonsoft.Json to System.Text.Json#74

Open
Stoom wants to merge 1 commit intorevoframework:developfrom
Incognitus-Dev:feature/system-text-json
Open

♻️ refactor: Newtonsoft.Json to System.Text.Json#74
Stoom wants to merge 1 commit intorevoframework:developfrom
Incognitus-Dev:feature/system-text-json

Conversation

@Stoom
Copy link
Copy Markdown

@Stoom Stoom commented Aug 8, 2024

Overview

This swaps out Newtonsoft.Json for the core library's System.Text.Json implementation.

Breaking changes

  • System.Text.Json does not read class attributes when inheriting a class. This means you'll need to add the [JsonConverter(typeof(SingleValueObjectJsonConverter))] attribute to any class that derives from SingleValueObject. One alternative would be to register a default json config and pull when setting up a serializer.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2024

Codecov Report

❌ Patch coverage is 50.84746% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.61%. Comparing base (2853441) to head (ec1f116).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...Extensions.Notifications/NotificationSerializer.cs 0.00% 8 Missing ⚠️
...istory/ChangeTracking/Model/EntityAttributeData.cs 55.55% 4 Missing ⚠️
....EFCore/DataAccess/Conventions/PrefixConvention.cs 0.00% 4 Missing ⚠️
...ore/ValueObjects/SingleValueObjectJsonConverter.cs 81.81% 1 Missing and 1 partial ⚠️
...structure/EventStores/Generic/Model/EventStream.cs 50.00% 2 Missing ⚠️
...iguration/EF6InfrastructureConfigurationSection.cs 0.00% 1 Missing ⚠️
Providers/EF6/Revo.EF6/Events/EF6EventsModule.cs 0.00% 1 Missing ⚠️
...ration/EFCoreInfrastructureConfigurationSection.cs 0.00% 1 Missing ⚠️
...Core/DataAccess/Conventions/LowerCaseConvention.cs 0.00% 1 Missing ⚠️
...cess/Conventions/SnakeCaseColumnNamesConvention.cs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #74      +/-   ##
===========================================
+ Coverage    35.54%   35.61%   +0.06%     
===========================================
  Files          472      472              
  Lines         6558     6537      -21     
  Branches       777      776       -1     
===========================================
- Hits          2331     2328       -3     
+ Misses        4122     4105      -17     
+ Partials       105      104       -1     
Files with missing lines Coverage Δ
...ory/ChangeTracking/TrackedChangeRecordConverter.cs 100.00% <100.00%> (ø)
Revo.Core/Events/JsonMetadata.cs 92.30% <100.00%> (ø)
Revo.Core/ValueObjects/SingleValueObject.cs 100.00% <ø> (ø)
...ture/Events/Async/AsyncEventProcessingException.cs 100.00% <ø> (+25.00%) ⬆️
...nts/Async/AsyncEventProcessingSequenceException.cs 66.66% <ø> (+16.66%) ⬆️
...structure/Validation/CommandValidationException.cs 0.00% <ø> (ø)
...iguration/EF6InfrastructureConfigurationSection.cs 0.00% <0.00%> (ø)
Providers/EF6/Revo.EF6/Events/EF6EventsModule.cs 0.00% <0.00%> (ø)
...ration/EFCoreInfrastructureConfigurationSection.cs 0.00% <0.00%> (ø)
...Core/DataAccess/Conventions/LowerCaseConvention.cs 0.00% <0.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2853441...ec1f116. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant