test(cli): add JSON contract tests for skills doctor + release check

Author: rexleimo

crates/loopforge-cli/src/dispatch/release.rs

@@ -13,7 +13,10 @@ pub(super) fn run(command: ReleaseCommand) -> anyhow::Result<()> {
         } => {
             let report = run_release_check(&repo_root, tag.as_deref(), run_tests)?;
             if json {
-                println!("{}", serde_json::to_string_pretty(&report)?);
+                println!(
+                    "{}",
+                    serde_json::to_string_pretty(&build_release_check_json(&report)?)?
+                );
             } else {
                 println!("{}", format_release_check_report(&report));
             }
@@ -24,3 +27,49 @@ pub(super) fn run(command: ReleaseCommand) -> anyhow::Result<()> {
         }
     }
 }
+
+fn build_release_check_json(
+    report: &crate::release_check::ReleaseCheckReport,
+) -> anyhow::Result<serde_json::Value> {
+    Ok(serde_json::to_value(report)?)
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::release_check::{ReleaseCheckItem, ReleaseCheckReport};
+    use serde_json::json;
+
+    #[test]
+    fn build_release_check_json_keeps_expected_shape() {
+        let report = ReleaseCheckReport {
+            ok: false,
+            tag: "v1.2.3".to_string(),
+            checks: vec![
+                ReleaseCheckItem {
+                    id: "alpha".to_string(),
+                    ok: true,
+                    message: "ok".to_string(),
+                },
+                ReleaseCheckItem {
+                    id: "beta".to_string(),
+                    ok: false,
+                    message: "missing".to_string(),
+                },
+            ],
+        };
+
+        let out = build_release_check_json(&report).unwrap();
+        assert_eq!(
+            out,
+            json!({
+                "ok": false,
+                "tag": "v1.2.3",
+                "checks": [
+                    { "id": "alpha", "ok": true, "message": "ok" },
+                    { "id": "beta", "ok": false, "message": "missing" },
+                ],
+            })
+        );
+    }
+}

crates/loopforge-cli/src/dispatch/skills/doctor.rs

@@ -5,7 +5,10 @@ use crate::skills;
 pub(super) fn run_doctor(workspace: PathBuf, json: bool, strict: bool) -> anyhow::Result<()> {
     let report = skills::doctor(&workspace)?;
     if json {
-        println!("{}", serde_json::to_string_pretty(&report)?);
+        println!(
+            "{}",
+            serde_json::to_string_pretty(&build_skills_doctor_json(&report)?)?
+        );
     } else {
         println!("discovered_skills: {}", report.discovered_count);
         if report.issues.is_empty() {
@@ -38,3 +41,51 @@ pub(super) fn run_doctor(workspace: PathBuf, json: bool, strict: bool) -> anyhow
     }
     Ok(())
 }
+
+fn build_skills_doctor_json(
+    report: &skills::SkillsDoctorReport,
+) -> anyhow::Result<serde_json::Value> {
+    Ok(serde_json::to_value(report)?)
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::skills::{SkillsDoctorIssue, SkillsDoctorLevel, SkillsDoctorReport};
+    use serde_json::json;
+
+    #[test]
+    fn build_skills_doctor_json_keeps_expected_shape_and_omits_missing_paths() {
+        let report = SkillsDoctorReport {
+            ok: false,
+            discovered_count: 2,
+            issues: vec![
+                SkillsDoctorIssue {
+                    level: SkillsDoctorLevel::Warn,
+                    id: "warn.test".to_string(),
+                    message: "warning".to_string(),
+                    path: None,
+                },
+                SkillsDoctorIssue {
+                    level: SkillsDoctorLevel::Error,
+                    id: "error.test".to_string(),
+                    message: "error".to_string(),
+                    path: Some("/tmp/skill.toml".to_string()),
+                },
+            ],
+        };
+
+        let out = build_skills_doctor_json(&report).unwrap();
+        assert_eq!(
+            out,
+            json!({
+                "ok": false,
+                "discovered_count": 2,
+                "issues": [
+                    { "level": "warn", "id": "warn.test", "message": "warning" },
+                    { "level": "error", "id": "error.test", "message": "error", "path": "/tmp/skill.toml" },
+                ]
+            })
+        );
+    }
+}