test(cli): add JSON output contract tests for doctor+config validate

Author: rexleimo

crates/loopforge-cli/src/dispatch/config.rs

@@ -8,7 +8,10 @@ pub(super) fn run(command: ConfigCommand) -> anyhow::Result<()> {
             let paths = RexosPaths::discover()?;
             let report = validate_config(&paths);
             if json {
-                println!("{}", serde_json::to_string_pretty(&report)?);
+                println!(
+                    "{}",
+                    serde_json::to_string_pretty(&build_config_validate_json(&report)?)?
+                );
             } else if report.valid {
                 println!("config valid: {}", report.config_path);
             } else {
@@ -25,3 +28,35 @@ pub(super) fn run(command: ConfigCommand) -> anyhow::Result<()> {
         }
     }
 }
+
+fn build_config_validate_json(
+    report: &crate::config_validation::ConfigValidationReport,
+) -> anyhow::Result<serde_json::Value> {
+    Ok(serde_json::to_value(report)?)
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::config_validation::ConfigValidationReport;
+    use serde_json::json;
+
+    #[test]
+    fn build_config_validate_json_keeps_expected_shape() {
+        let report = ConfigValidationReport {
+            valid: false,
+            config_path: "/tmp/config.toml".to_string(),
+            errors: vec!["router.planning.provider is empty".to_string()],
+        };
+
+        let out = build_config_validate_json(&report).unwrap();
+        assert_eq!(
+            out,
+            json!({
+                "valid": false,
+                "config_path": "/tmp/config.toml",
+                "errors": ["router.planning.provider is empty"],
+            })
+        );
+    }
+}

crates/loopforge-cli/src/dispatch/doctor.rs

@@ -11,7 +11,10 @@ pub(super) async fn run(json: bool, strict: bool, timeout_ms: u64) -> anyhow::Re
     .await?;
 
     if json {
-        println!("{}", serde_json::to_string_pretty(&report)?);
+        println!(
+            "{}",
+            serde_json::to_string_pretty(&build_doctor_json(&report)?)?
+        );
     } else {
         println!("{}", report.to_text());
     }
@@ -22,3 +25,50 @@ pub(super) async fn run(json: bool, strict: bool, timeout_ms: u64) -> anyhow::Re
     }
     Ok(())
 }
+
+fn build_doctor_json(report: &doctor::DoctorReport) -> anyhow::Result<serde_json::Value> {
+    Ok(serde_json::to_value(report)?)
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::doctor::{CheckStatus, DoctorCheck, DoctorReport, DoctorSummary};
+    use serde_json::json;
+
+    #[test]
+    fn build_doctor_json_keeps_expected_shape_and_omits_empty_fields() {
+        let report = DoctorReport {
+            checks: vec![
+                DoctorCheck {
+                    id: "alpha".to_string(),
+                    status: CheckStatus::Ok,
+                    message: String::new(),
+                },
+                DoctorCheck {
+                    id: "beta".to_string(),
+                    status: CheckStatus::Warn,
+                    message: "missing env".to_string(),
+                },
+            ],
+            summary: DoctorSummary {
+                ok: 1,
+                warn: 1,
+                error: 0,
+            },
+            next_actions: Vec::new(),
+        };
+
+        let out = build_doctor_json(&report).unwrap();
+        assert_eq!(
+            out,
+            json!({
+                "checks": [
+                    { "id": "alpha", "status": "ok" },
+                    { "id": "beta", "status": "warn", "message": "missing env" },
+                ],
+                "summary": { "ok": 1, "warn": 1, "error": 0 },
+            })
+        );
+    }
+}