Conversation
Also, save DR coordinates into Sights.xml
- widen lunar altitude fields - make pressure precision a hundreth, temperature precision a tenth - fix duplicate formula in Calculate output
Retain 2 decimal digits for eye height as well
Thanks to OpenCPN provided fromDMM_Plugin() function, all degrees-like measurements (heights, longitudes, latitudes, etc) can now be entered in multiple formats like: - 37°54.204' N - N37 54 12 - 37°54'12" - 37.9034 - 122°18.621' W - 122w 18 37 -122.31035 Some fields have also been changed to print the measurement is standardized DD° MM.MMMM' format instead of a double value.
Owner
Author
|
I've build and run this locally. It looks good. |
Owner
Author
|
@copilot Where to review? |
Celestial Navigation Plugin: Lunar Distance, Sight Enhancements, and Platform Support
Owner
Author
|
@stelian42 It won't let me merge without someone's review and approval other than me. I can override it but would rather not. Can you review it? |
Owner
Author
|
Oh I guess copilot did the review and then when I reviewed that, the PR was merged into master. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.