Skip to content

download control binaries to tarball#297

Open
maorfr wants to merge 1 commit into
mainfrom
download-binaries-tarball
Open

download control binaries to tarball#297
maorfr wants to merge 1 commit into
mainfrom
download-binaries-tarball

Conversation

@maorfr
Copy link
Copy Markdown
Collaborator

@maorfr maorfr commented Apr 26, 2026

avoid download dependency at runtime (but adds to the tarball size).

this removes a dependency on download sources which may be unreliable and cause a blocker during install time.
for example, we are downloading clairctl from github, which can not be trusted (you heard me github).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@maorfr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 57 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 57 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1275b8c6-afa7-4c08-85b1-aaf73b6607f2

📥 Commits

Reviewing files that changed from the base of the PR and between 5dac976 and bcc3003.

📒 Files selected for processing (1)
  • .github/workflows/build-push-tarball.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch download-binaries-tarball

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ci-cd CI/CD infrastructure label Apr 26, 2026
@github-actions
Copy link
Copy Markdown

Tarball created: quay.io/edge-infrastructure/enclave:18b2f9726ca4b1d86c8281239a9fb59cdca4c197 (18b2f97)

@rporres
Copy link
Copy Markdown
Contributor

rporres commented Apr 27, 2026

Why are we doing this?

@maorfr
Copy link
Copy Markdown
Collaborator Author

maorfr commented Apr 27, 2026

Why are we doing this?

updated the description

@maorfr maorfr added the hold hold a pull request from being merged label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD infrastructure hold hold a pull request from being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants