Skip to content

Commit 5efc539

Browse files
TomerNewmanybettan
authored andcommitted
Adding delete to modulebuildsignconfigs rbac
Following "Add imageRebuildTrigger field to force module image rebuilds" commit, we now deleting mbsc resources from the controllers (regular + hub) pods, but since we missed the rbac annotation for that, it failed to delete. This commits adds the missing rbac annotation.
1 parent 094cd87 commit 5efc539

6 files changed

Lines changed: 8 additions & 26 deletions

File tree

bundle-hub/manifests/kernel-module-management-hub.clusterserviceversion.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ metadata:
3737
}
3838
]
3939
capabilities: Seamless Upgrades
40-
createdAt: "2026-02-15T12:41:06Z"
40+
createdAt: "2026-02-17T13:40:33Z"
4141
operatorframework.io/suggested-namespace: openshift-kmm-hub
4242
operators.operatorframework.io/builder: operator-sdk-v1.41.1
4343
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
@@ -159,6 +159,7 @@ spec:
159159
- modulebuildsignconfigs
160160
verbs:
161161
- create
162+
- delete
162163
- get
163164
- list
164165
- patch

bundle/manifests/kernel-module-management.clusterserviceversion.yaml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ metadata:
4747
}
4848
]
4949
capabilities: Seamless Upgrades
50-
createdAt: "2026-02-15T12:40:55Z"
50+
createdAt: "2026-02-17T13:38:08Z"
5151
operatorframework.io/suggested-namespace: openshift-kmm
5252
operators.operatorframework.io/builder: operator-sdk-v1.41.1
5353
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
@@ -207,6 +207,7 @@ spec:
207207
- kmm.sigs.x-k8s.io
208208
resources:
209209
- bootmoduleconfigs
210+
- modulebuildsignconfigs
210211
- preflightvalidations
211212
- preflightvalidationsocp
212213
verbs:
@@ -227,17 +228,6 @@ spec:
227228
verbs:
228229
- patch
229230
- update
230-
- apiGroups:
231-
- kmm.sigs.x-k8s.io
232-
resources:
233-
- modulebuildsignconfigs
234-
verbs:
235-
- create
236-
- get
237-
- list
238-
- patch
239-
- update
240-
- watch
241231
- apiGroups:
242232
- kmm.sigs.x-k8s.io
243233
resources:

config/rbac-hub/role.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ rules:
8383
- modulebuildsignconfigs
8484
verbs:
8585
- create
86+
- delete
8687
- get
8788
- list
8889
- patch

config/rbac/role.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ rules:
9696
- kmm.sigs.x-k8s.io
9797
resources:
9898
- bootmoduleconfigs
99+
- modulebuildsignconfigs
99100
- preflightvalidations
100101
- preflightvalidationsocp
101102
verbs:
@@ -116,17 +117,6 @@ rules:
116117
verbs:
117118
- patch
118119
- update
119-
- apiGroups:
120-
- kmm.sigs.x-k8s.io
121-
resources:
122-
- modulebuildsignconfigs
123-
verbs:
124-
- create
125-
- get
126-
- list
127-
- patch
128-
- update
129-
- watch
130120
- apiGroups:
131121
- kmm.sigs.x-k8s.io
132122
resources:

internal/controllers/hub/managedclustermodule_reconciler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ type ManagedClusterModuleReconciler struct {
6666
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=moduleimagesconfigs,verbs=get;list;watch;patch;create;delete
6767
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=moduleimagesconfigs/status,verbs=get;update;patch
6868
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=moduleimagesconfigs/finalizers,verbs=update
69-
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs,verbs=get;list;watch;update;patch;create
69+
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs,verbs=get;list;watch;update;patch;create;delete
7070
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs/status,verbs=get;update;patch
7171
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs/finalizers,verbs=update
7272
//+kubebuilder:rbac:groups=work.open-cluster-management.io,resources=manifestworks,verbs=get;list;watch;create;update;patch;delete

internal/controllers/module_reconciler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import (
4343
// +kubebuilder:rbac:groups=core,resources=pods,verbs=create;delete;get;list;patch;watch
4444
// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch
4545
// +kubebuilder:rbac:groups=core,resources=serviceaccounts,verbs=get;list;watch
46-
// +kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs,verbs=create;get;list;patch;update;watch
46+
// +kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs,verbs=create;delete;get;list;patch;update;watch
4747
// +kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs/status,verbs=get;patch;update
4848
// +kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs/finalizers,verbs=update
4949

0 commit comments

Comments
 (0)