Skip to content

Register DRA reconciler with manager#1828

Merged
openshift-merge-bot[bot] merged 1 commit into
rh-ecosystem-edge:mainfrom
TomerNewman:register-dra
Jun 24, 2026
Merged

Register DRA reconciler with manager#1828
openshift-merge-bot[bot] merged 1 commit into
rh-ecosystem-edge:mainfrom
TomerNewman:register-dra

Conversation

@TomerNewman

@TomerNewman TomerNewman commented Jun 23, 2026

Copy link
Copy Markdown
Member

Wire the DRA reconciler into the operator manager
fix #1824

Summary by CodeRabbit

  • New Features

    • Added support for Kubernetes Dynamic Resource Allocation API.
  • Improvements

    • Enhanced error handling for controller initialization.

Wire the DRA reconciler into the operator manager
@netlify

netlify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit d590da3
🔍 Latest deploy log https://app.netlify.com/projects/openshift-kmm/deploys/6a3a9ab54fdd900008ca228c
😎 Deploy Preview https://deploy-preview-1828--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

In cmd/manager/main.go, the k8s.io/api/resource/v1 package is imported as resourcev1, its scheme types are registered in init(), and a new DRAReconciler is constructed via controllers.NewDRAReconciler and wired into the manager with SetupWithManager, fataling on error.

DRA Reconciler Wiring

Layer / File(s) Summary
resourcev1 scheme registration and DRAReconciler setup
cmd/manager/main.go
Adds resourcev1 import, registers it with the manager scheme in init(), and instantiates controllers.NewDRAReconciler(client, nodeAPI, scheme) with SetupWithManager(mgr) error handling that calls cmd.FatalError on failure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Register DRA reconciler with manager' directly and accurately describes the main change in the pull request, which is registering the Dynamic Resource Allocation (DRA) reconciler with the manager.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TomerNewman

Copy link
Copy Markdown
Member Author

/cc @ybettan
/assign @yevgeny-shnaidman @ybettan
/uncc @enriquebelarte

@openshift-ci openshift-ci Bot requested review from ybettan and removed request for enriquebelarte June 23, 2026 14:41
@yevgeny-shnaidman

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 24, 2026
@TomerNewman

Copy link
Copy Markdown
Member Author

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 53251bd into rh-ecosystem-edge:main Jun 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cherry-picking error for 40f1f16500f50d6f8dae6aac5d2ef5ce3d0c6f2e

3 participants