Skip to content

Cherry-pick 29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88 from upstream#1829

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
gs-29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88
Jun 24, 2026
Merged

Cherry-pick 29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88 from upstream#1829
openshift-merge-bot[bot] merged 1 commit into
mainfrom
gs-29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick by gitstream of 29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88 from https://github.com/kubernetes-sigs/kernel-module-management.

Commit message:

Restrict device plugin hostPath volumes to allowed prefixes

Add webhook validation that rejects hostPath volumes in
spec.devicePlugin.volumes unless the path resolves under /dev, /sys,
/var or /opt. This prevents device plugins from mounting arbitrary
host directories such as / or /etc.


Upstream-Commit: 29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88

Add webhook validation that rejects hostPath volumes in
spec.devicePlugin.volumes unless the path resolves under /dev, /sys,
/var or /opt. This prevents device plugins from mounting arbitrary
host directories such as / or /etc.


Upstream-Commit: 29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88
@github-actions github-actions Bot marked this pull request as ready for review June 23, 2026 16:06
@netlify

netlify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 733a63a
🔍 Latest deploy log https://app.netlify.com/projects/openshift-kmm/deploys/6a3aaf188e002100071242dd
😎 Deploy Preview https://deploy-preview-1829--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TomerNewman

Copy link
Copy Markdown
Member

/ok-to-test
/approve
/assign @yevgeny-shnaidman @ybettan
/cc @yevgeny-shnaidman @ybettan
/uncc @bthurber

@openshift-ci openshift-ci Bot removed the request for review from bthurber June 24, 2026 05:48
@openshift-ci openshift-ci Bot requested a review from ybettan June 24, 2026 05:48
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: github-actions[bot], TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yevgeny-shnaidman

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 24, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit d29f544 into main Jun 24, 2026
20 checks passed
@TomerNewman TomerNewman deleted the gs-29c905a152b5cbc8ab67b2cc758ef3f7c8f58d88 branch June 24, 2026 07:15
@TomerNewman

Copy link
Copy Markdown
Member

/cherry-pick release-2.6
/cherry-pick release-2.5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@TomerNewman: #1829 failed to apply on top of branch "release-2.5":

Applying: Restrict device plugin hostPath volumes to allowed prefixes
Using index info to reconstruct a base tree...
M	internal/webhook/module.go
M	internal/webhook/module_test.go
Falling back to patching base and 3-way merge...
Auto-merging internal/webhook/module.go
CONFLICT (content): Merge conflict in internal/webhook/module.go
Auto-merging internal/webhook/module_test.go
CONFLICT (content): Merge conflict in internal/webhook/module_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Restrict device plugin hostPath volumes to allowed prefixes

Details

In response to this:

/cherry-pick release-2.6
/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@TomerNewman: #1829 failed to apply on top of branch "release-2.6":

Applying: Restrict device plugin hostPath volumes to allowed prefixes
Using index info to reconstruct a base tree...
M	internal/webhook/module.go
M	internal/webhook/module_test.go
Falling back to patching base and 3-way merge...
Auto-merging internal/webhook/module.go
CONFLICT (content): Merge conflict in internal/webhook/module.go
Auto-merging internal/webhook/module_test.go
CONFLICT (content): Merge conflict in internal/webhook/module_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Restrict device plugin hostPath volumes to allowed prefixes

Details

In response to this:

/cherry-pick release-2.6
/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants