Add missing RBAC for DRA driver ServiceAccount#1840
Conversation
The kubeletplugin library requires nodes read access to look up the node UID when publishing ResourceSlices, and resourceclaims read access during PrepareResourceClaims. Without these, any DRA driver deployed through KMM fails at runtime.
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR adds ChangesDRA RBAC and CSV metadata updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm |
080def7
into
rh-ecosystem-edge:main
The kubeletplugin library requires nodes read access to look up the node UID when publishing ResourceSlices, and resourceclaims read access during PrepareResourceClaims. Without these, any DRA driver deployed through KMM fails at runtime.
reference to NVIDIA's rbac for dra driver pod https://github.com/kubernetes-sigs/dra-driver-nvidia-gpu/blob/main/deployments/helm/dra-driver-nvidia-gpu/templates/rbac-kubeletplugin.yaml#L3
/cc @yevgeny-shnaidman
/assign @yevgeny-shnaidman
Summary by CodeRabbit
New Features
Chores