Skip to content

Add missing RBAC for DRA driver ServiceAccount#1840

Merged
openshift-merge-bot[bot] merged 1 commit into
rh-ecosystem-edge:mainfrom
TomerNewman:add-missing-rbac-dra
Jul 1, 2026
Merged

Add missing RBAC for DRA driver ServiceAccount#1840
openshift-merge-bot[bot] merged 1 commit into
rh-ecosystem-edge:mainfrom
TomerNewman:add-missing-rbac-dra

Conversation

@TomerNewman

@TomerNewman TomerNewman commented Jul 1, 2026

Copy link
Copy Markdown
Member

The kubeletplugin library requires nodes read access to look up the node UID when publishing ResourceSlices, and resourceclaims read access during PrepareResourceClaims. Without these, any DRA driver deployed through KMM fails at runtime.

reference to NVIDIA's rbac for dra driver pod https://github.com/kubernetes-sigs/dra-driver-nvidia-gpu/blob/main/deployments/helm/dra-driver-nvidia-gpu/templates/rbac-kubeletplugin.yaml#L3


/cc @yevgeny-shnaidman
/assign @yevgeny-shnaidman

Summary by CodeRabbit

  • New Features

    • Expanded cluster permissions to allow broader access to node and resource claim information, improving compatibility with dynamic resource allocation workflows.
  • Chores

    • Updated release manifest timestamps to reflect the latest build metadata.

The kubeletplugin library requires nodes read access to look up the
node UID when publishing ResourceSlices, and resourceclaims read
access during PrepareResourceClaims. Without these, any DRA driver
deployed through KMM fails at runtime.
@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 0752197
🔍 Latest deploy log https://app.netlify.com/projects/openshift-kmm/deploys/6a44c7a423407e0008aebc0a
😎 Deploy Preview https://deploy-preview-1840--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested a review from yevgeny-shnaidman July 1, 2026 07:54
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d8f826a-ee6d-4dec-abb0-6f1cd23bd2ed

📥 Commits

Reviewing files that changed from the base of the PR and between 65e60bf and 0752197.

📒 Files selected for processing (3)
  • bundle-hub/manifests/kernel-module-management-hub.clusterserviceversion.yaml
  • bundle/manifests/kernel-module-management.clusterserviceversion.yaml
  • config/rbac/dra_cluster_role.yaml

Walkthrough

This PR adds get/list/watch RBAC permissions for resourceclaims (resource.k8s.io) and nodes (core API) to the dra ClusterRole and mirrors these rules into the bundle CSV's kmm-operator-dra clusterPermissions. CSV createdAt timestamps are also updated.

Changes

DRA RBAC and CSV metadata updates

Layer / File(s) Summary
DRA ClusterRole RBAC rules
config/rbac/dra_cluster_role.yaml
Adds two rules granting get/list/watch on resourceclaims (resource.k8s.io) and nodes (core API) to the dra ClusterRole.
Bundle CSV RBAC and timestamp updates
bundle/manifests/kernel-module-management.clusterserviceversion.yaml, bundle-hub/manifests/kernel-module-management-hub.clusterserviceversion.yaml
Mirrors the resourceclaims/nodes RBAC rules into the kmm-operator-dra clusterPermissions and updates createdAt timestamps in both CSV manifests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: lgtm

Suggested reviewers: yevgeny-shnaidman, ybettan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding missing RBAC permissions for the DRA driver ServiceAccount.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yevgeny-shnaidman

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 080def7 into rh-ecosystem-edge:main Jul 1, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants