TESTING: Migrate Argo CD Dockerfile to use pnpm#1004
Open
nmirasch wants to merge 1 commit into
Open
Conversation
Assisted-by: Cursor
svghadi
reviewed
Jun 15, 2026
Comment on lines
-24
to
-29
| # Install Yarn | ||
| WORKDIR /usr/src/app | ||
| COPY ["prefetch/yarn/package.json", "prefetch/yarn/package-lock.json", "./"] | ||
| RUN npm install --prefer-offline --no-progress --non-interactive | ||
| ENV YARN="/usr/src/app/node_modules/.bin/yarn" | ||
| RUN $YARN --version |
Collaborator
There was a problem hiding this comment.
Is it possible to install pnpm in this manner? Ideally we should request the registry.access.redhat.com/ubi9/nodejs-22 maintainers to have pnpm bundled in the image but that will take time.
Collaborator
|
Looks good overall. The conforma failure is expected and we can get it fixed later via policy exception. We should now look into using Nexus registry as proxy. Please ping me on slack, I will share the registry details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Cursor