rosa cost explorer#959
Merged
Merged
Conversation
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
michaelryanmcneill
requested changes
Jul 2, 2026
michaelryanmcneill
left a comment
michaelryanmcneill
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Three specific things:
- In the top three squares (Baseline, Current Estimate, Monthly Savings), the $ is duplicated in the smaller text.
- Can you fix the header to have the full menu instead of just the ROSA link?
- Can you ensure the page has the cookie manager JS in place so that it renders the cookie warning if someone lands directly on the page?
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.