[pull] main from patternfly:main#26
Merged
Merged
Conversation
Adds optional props for customizing all user-facing strings in BulkSelect to support internationalization and custom terminology. All changes are backward compatible with sensible English defaults. New props: - selectNoneLabel: Custom label for "Select none" option - selectPageLabel: Function receiving pageCount to format "Select page" label - selectAllLabel: Function receiving totalCount to format "Select all" label - selectedLabel: Function receiving selectedCount to format the displayed count Implementation details: - Default label functions are hoisted to module level for stable references - Label functions are called inside useMemo to prevent unnecessary re-renders - Optimized for performance with expensive operations like pseudolocalization - Parameter names avoid i18n reserved keywords (e.g., 'count' for pluralization) Fixes #895 Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )