Add null terminator at the end of entry data#230
Open
zundamo-ti wants to merge 1 commit into
Open
Conversation
Signed-off-by: zundamo-ti <ykato1729@gmail.com>
14bb6f6 to
8ead2fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: add UCS-2 null terminator to --unicode optional data
Fixes #229
When
--unicodeis used, the optional data in the EFI load option is not null-terminated. This causes shim'ssplit_load_options()to fail to extract the second-stage loader path, as it requires a space or null delimiter to identify the end of the path string.Changes
In
make_var():--unicodeis setefi_set_variable()Testing
Tested on Azure CVM (SEV-SNP) with Ubuntu 24.04 and shim + UKI boot chain.
Before fix:
efibootmgr --create --unicodeproduces optional data without null terminatorAfter fix:
00 00