grub-get-kernel-settings: Treate kernel-uki-dtbloader as default kernel#214
Open
jwrdegoede wants to merge 1 commit into
Open
grub-get-kernel-settings: Treate kernel-uki-dtbloader as default kernel#214jwrdegoede wants to merge 1 commit into
jwrdegoede wants to merge 1 commit into
Conversation
kernel-uki-dtbloader is a drop-in replacement for kernel-core, it even conflicts with kernel-core since it uses identical filenames under /boot. Before this patch grub-get-kernel-settings handled kernel-uki-dtbloader as a special kernel variant, causing GRUB_NON_STANDARD_KERNEL=true to get set which leads to /lib/kernel/install.d/20-grub.install setting GRUB_UPDATE_DEFAULT_KERNEL=false which results in skipping the grub2-set-default call later on during kernel-install. As a result of this users of Fedora 44+ ARM64 live media which uses kernel-uki-dtbloader would still get the old kernel on reboot after installing kernel updates (Bug 2463620 - GRUB environment variable saved_entry not updated when installing UKI kernel on F44 aarch64). Resolve this by treating kernel-uki-dtbloader as default kernel, just like how kernel-core is handled. Note on the next rebase of rhboot/grub this may be merged into commit c5baa5c ("Add grub-get-kernel-settings and use it in 10_linux") Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2463620 Fixes: c5baa5c ("Add grub-get-kernel-settings and use it in 10_linux") Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernel-uki-dtbloader is a drop-in replacement for kernel-core, it even conflicts with kernel-core since it uses identical filenames under /boot.
Before this patch grub-get-kernel-settings handled kernel-uki-dtbloader as a special kernel variant, causing GRUB_NON_STANDARD_KERNEL=true to get set which leads to /lib/kernel/install.d/20-grub.install setting GRUB_UPDATE_DEFAULT_KERNEL=false which results in skipping the grub2-set-default call later on during kernel-install.
As a result of this users of Fedora 44+ ARM64 live media which uses kernel-uki-dtbloader would still get the old kernel on reboot after installing kernel updates (Bug 2463620 - GRUB environment variable saved_entry not updated when installing UKI kernel on F44 aarch64).
Resolve this by treating kernel-uki-dtbloader as default kernel, just like how kernel-core is handled.
Note on the next rebase of rhboot/grub this may be merged into commit c5baa5c ("Add grub-get-kernel-settings and use it in 10_linux")
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2463620
Fixes: c5baa5c ("Add grub-get-kernel-settings and use it in 10_linux")
I'll also submit a https://src.fedoraproject.org/rpms/grub2/ PR for this with the dist-git bits.