This repository was archived by the owner on Sep 12, 2021. It is now read-only.
Allow access to component factory for sub-classes.#69
Open
guw wants to merge 1 commit into
Open
Conversation
rherrmann
suggested changes
Oct 13, 2016
Owner
rherrmann
left a comment
rherrmann
left a comment
There was a problem hiding this comment.
In this case, the test may also serve as a place to have a comment that points to this issue to explain why the otherwise unused method exists.
In addition, I would declare the method as public to better align with the existing setConsoleComponentFactory()
The component factory is used by the content assist. When used outside of a console page (the Eclipse console view) the content assist needs to be created manually. Thus, access to the component factory is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component factory is used by the content assist. When used outside
of a console page (the Eclipse console view) the content assist needs to
be created manually. Thus, access to the component factory is necessary.