test: use dedicated namespace for health-analyzer e2e PrometheusRule

Move the test PrometheusRule from openshift-monitoring to a throwaway
namespace labeled with openshift.io/cluster-monitoring=true. The
platform Prometheus picks up rules from any namespace with that label,
so the test still works but avoids writing into a shared system
namespace.

Made-with: Cursor

Author: DavidRajnoha

test/e2e/uiplugin_cluster_health_analyzer_test.go

@@ -11,6 +11,7 @@ import (
 	"github.com/prometheus/common/model"
 	"gotest.tools/v3/assert"
 	appsv1 "k8s.io/api/apps/v1"
+	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
@@ -22,7 +23,7 @@ import (
 
 const (
 	healthAnalyzerDeploymentName = "health-analyzer"
-	prometheusRuleNamespace      = "openshift-monitoring"
+	prometheusRuleNamespace      = "e2e-health-analyzer-rules"
 )
 
 func clusterHealthAnalyzer(t *testing.T) {
@@ -50,6 +51,8 @@ func clusterHealthAnalyzer(t *testing.T) {
 	ruleName := "e2e-health-analyzer-" + suffix
 	alertName := "E2EHealthAnalyzer" + suffix
 
+	createRuleNamespace(t, prometheusRuleNamespace)
+
 	rule := newAlwaysFiringRule(t, ruleName, alertName)
 	err = f.K8sClient.Create(t.Context(), rule)
 	assert.NilError(t, err, "failed to create PrometheusRule")
@@ -122,17 +125,30 @@ func newMonitoringUIPlugin(t *testing.T) *uiv1.UIPlugin {
 	return plugin
 }
 
+func createRuleNamespace(t *testing.T, name string) {
+	t.Helper()
+	ns := &corev1.Namespace{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: name,
+			Labels: map[string]string{
+				"openshift.io/cluster-monitoring": "true",
+			},
+		},
+	}
+	if err := f.K8sClient.Create(t.Context(), ns); err != nil && !errors.IsAlreadyExists(err) {
+		t.Fatalf("failed to create rule namespace %s: %v", name, err)
+	}
+	f.CleanUp(t, func() {
+		ctx := context.WithoutCancel(t.Context())
+		f.K8sClient.Delete(ctx, ns)
+	})
+}
+
 func newAlwaysFiringRule(t *testing.T, ruleName, alertName string) *monv1.PrometheusRule {
 	rule := &monv1.PrometheusRule{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      ruleName,
 			Namespace: prometheusRuleNamespace,
-			Labels: map[string]string{
-				"app.kubernetes.io/name":    "kube-prometheus",
-				"app.kubernetes.io/part-of": "openshift-monitoring",
-				"prometheus":                "k8s",
-				"role":                      "alert-rules",
-			},
 		},
 		Spec: monv1.PrometheusRuleSpec{
 			Groups: []monv1.RuleGroup{{