Skip to content

COO-1557: apply TLS profile to COO#1088

Open
simonpasquier wants to merge 1 commit into
rhobs:mainfrom
simonpasquier:COO-1557
Open

COO-1557: apply TLS profile to COO#1088
simonpasquier wants to merge 1 commit into
rhobs:mainfrom
simonpasquier:COO-1557

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented May 11, 2026

@simonpasquier: This pull request references COO-1557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5005ddb9-9869-410a-8b34-f88a12ce16f6

📥 Commits

Reviewing files that changed from the base of the PR and between 7b71dde and 5b408e3.

📒 Files selected for processing (1)
  • pkg/operator/operator.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/operator/operator.go

📝 Walkthrough

Walkthrough

This pull request introduces a top-level TLSProfile field to OperatorConfiguration and uses it to configure OpenShift TLS security. The WithTLSProfile() builder now sets both the operator-level TLSProfile and the nested UIPlugins.TLSProfile. A single shared setupLog logger is initialized once in New() and reused across all code paths, eliminating redundant redeclarations. The OpenShift-enabled serving certificate controller derives a tls.Config from the TLSProfile via openshifttls.NewTLSConfigFromProfile, explicitly sets ClientAuth to require client certificate verification, and passes this config to NewDynamicServingCertificateController. The OpenShift security profile watcher is configured to use cfg.TLSProfile as its initial spec.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the TLS profile changes, their purpose, and impact on the operator's security configuration.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the main change: applying TLS profile to COO, which matches the changeset's core functionality of adding TLSProfile field and applying it throughout the operator.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@simonpasquier
Copy link
Copy Markdown
Contributor Author

/hold

waiting for #1090

This commit passes the TLS configuration read from the cluster TLS
profile to the operator's HTTPS server.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Copy Markdown
Contributor Author

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants