test: increase timeout for OCP tests#1146
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangestest/run-e2e.sh now derives its Go e2e test timeout from an optional TEST_TIMEOUT environment variable, defaulting to 15m when unset, and adjusts the alignment/spacing of the print_config() heredoc output. test/run-e2e-ocp.sh sets TEST_TIMEOUT to 30m by default before invoking test/run-e2e.sh, giving OpenShift runs a longer timeout while preserving existing install/uninstall control flow. Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant run_e2e_ocp as run-e2e-ocp.sh
participant run_e2e as run-e2e.sh
run_e2e_ocp->>run_e2e_ocp: export TEST_TIMEOUT=30m (if unset)
run_e2e_ocp->>run_e2e: invoke ./test/run-e2e.sh
run_e2e->>run_e2e: TEST_TIMEOUT=${TEST_TIMEOUT:-15m}
run_e2e->>run_e2e: print_config() with reformatted output
Related issues: None specified. Related PRs: None specified. Suggested labels: test, ci Suggested reviewers: None specified. Poem 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
fdda3ae to
d26d61a
Compare
|
/lgtm |
It should help for https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat/2072091417852776448