Skip to content

test: increase timeout for OCP tests#1146

Merged
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
simonpasquier:increase-test-timeout-for-ocp
Jul 1, 2026
Merged

test: increase timeout for OCP tests#1146
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
simonpasquier:increase-test-timeout-for-ocp

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2c4ae1f1-1047-407f-b2de-a1771832db52

📥 Commits

Reviewing files that changed from the base of the PR and between fdda3ae and d26d61a.

📒 Files selected for processing (2)
  • test/run-e2e-ocp.sh
  • test/run-e2e.sh
✅ Files skipped from review due to trivial changes (1)
  • test/run-e2e.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/run-e2e-ocp.sh

📝 Walkthrough

Walkthrough

Changes

test/run-e2e.sh now derives its Go e2e test timeout from an optional TEST_TIMEOUT environment variable, defaulting to 15m when unset, and adjusts the alignment/spacing of the print_config() heredoc output. test/run-e2e-ocp.sh sets TEST_TIMEOUT to 30m by default before invoking test/run-e2e.sh, giving OpenShift runs a longer timeout while preserving existing install/uninstall control flow.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Sequence Diagram(s)

sequenceDiagram
  participant run_e2e_ocp as run-e2e-ocp.sh
  participant run_e2e as run-e2e.sh
  run_e2e_ocp->>run_e2e_ocp: export TEST_TIMEOUT=30m (if unset)
  run_e2e_ocp->>run_e2e: invoke ./test/run-e2e.sh
  run_e2e->>run_e2e: TEST_TIMEOUT=${TEST_TIMEOUT:-15m}
  run_e2e->>run_e2e: print_config() with reformatted output
Loading

Related issues: None specified.

Related PRs: None specified.

Suggested labels: test, ci

Suggested reviewers: None specified.

Poem
A rabbit checks the clock with care,
Thirty minutes now on OpenShift's air,
Fifteen the default, still fair and neat,
The config lines now aligned and sweet,
Hop, hop, hooray, no timeout defeat! 🐰⏱️

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: increasing the OCP test timeout.
Description check ✅ Passed The description is related to the CI issue the timeout change aims to address.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier force-pushed the increase-test-timeout-for-ocp branch from fdda3ae to d26d61a Compare July 1, 2026 13:54
@danielmellado

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit af76d49 into rhobs:main Jul 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants