Skip to content

chore: remove unused field in controllers#1147

Merged
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
simonpasquier:remove-unused-field
Jul 6, 2026
Merged

chore: remove unused field in controllers#1147
openshift-merge-bot[bot] merged 1 commit into
rhobs:mainfrom
simonpasquier:remove-unused-field

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot requested review from jgbernalp and marioferh July 3, 2026 08:06
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change refactors controller registration logic in four controller files (monitoring-stack, operator, uiplugin, observability). In three files, the resourceManager struct no longer stores a controller.Controller field, and unused imports were removed; RegisterWithManager now returns the builder chain directly via Complete(rm) instead of calling Build(rm) with manual error handling and field assignment. In the observability controller, the builder chain was inlined but the built controller is still assigned to a struct field.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related PRs: None identified from the provided context.

Suggested labels: refactor, controllers

Suggested reviewers: None identified from the provided context.

🐰 Four controllers, tidied with care,
Unused fields swept out of the air,
Build became Complete, clean and neat,
One less variable, one less repeat,
Hopping through code, light as a feather.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No PR description was provided, so the check cannot assess whether it summarizes the changeset. Add a brief description of the controller refactor and unused-field removal.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: removing an unused controller field from controller implementations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jan--f

jan--f commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 6, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 8ee6ecc into rhobs:main Jul 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants