Skip to content

chore: log or return error #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonpasquier wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −7
Open

chore: log or return error #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/controllers/monitoring/monitoring-stack/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ func (rm resourceManager) getStack(ctx context.Context, req ctrl.Request) (*stac
logger.V(3).Info("stack could not be found; may be marked for deletion")
return nil, nil
}
logger.Error(err, "failed to get monitoring stack")
return nil, err
}

Expand Down
4 changes: 0 additions & 4 deletions pkg/controllers/observability/observability_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,13 @@ func (o observabilityInstallerController) Reconcile(ctx context.Context, request
// List all subscriptions to figure out if the operators are already installed
err = o.apiReader.List(ctx, subs, &client.ListOptions{})
if err != nil {
o.logger.Error(err, "Failed to list subscriptions")
return ctrl.Result{}, err
}
reconcilers, err := getReconcilers(ctx, o.client, o.apiReader, instance, o.Options, operatorsStatus{
cooNamespace: o.Options.COONamespace,
subs: subs.Items,
})
if err != nil {
o.logger.Error(err, "Failed to get reconcilers")
return ctrl.Result{}, err
}
for _, reconciler := range reconcilers {
Expand All @@ -129,7 +127,6 @@ func (o observabilityInstallerController) Reconcile(ctx context.Context, request

groups, err := o.discoveryClient.ServerGroups()
if err != nil {
o.logger.Error(err, "Failed to get server groups / CDRs")
return ctrl.Result{}, fmt.Errorf("failed to get server groups: %w", err)
}
for _, group := range groups.Groups {
Expand Down Expand Up @@ -196,7 +193,6 @@ func (o observabilityInstallerController) getInstance(ctx context.Context, req c
o.logger.V(3).Info("instance could not be found; may be marked for deletion")
return nil, nil
}
o.logger.Error(err, "failed to get cluster observability instance")
return nil, err
}

Expand Down
2 changes: 0 additions & 2 deletions pkg/controllers/uiplugin/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func RegisterWithManager(mgr ctrl.Manager, opts Options) error {

dynamicClient, err := dynamic.NewForConfig(mgr.GetConfig())
if err != nil {
logger.Error(err, "failed to create dynamic client")
return err
}

Expand Down Expand Up @@ -424,7 +423,6 @@ func (rm resourceManager) getUIPlugin(ctx context.Context, req ctrl.Request) (*u
logger.V(3).Info("stack could not be found; may be marked for deletion")
return nil, nil
}
logger.Error(err, "failed to get UIPlugin")
return nil, err
}

Expand Down
Loading