fix(matrix): reject array values in include/exclude for scalar keys#664
Open
leno23 wants to merge 1 commit into
Open
fix(matrix): reject array values in include/exclude for scalar keys#664leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When a matrix dimension lists scalar values, wrapping them in a YAML sequence in include or exclude fails at runtime. Fixes rhysd#630. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeorexcludeuses a YAML sequence for a matrix key whosematrix:dimension uses scalar values (e.g.php: ['8.2']instead ofphp: '8.2')include(such as runner label lists) may still use arraysexcludeas beforeFixes #630
Test plan
go test ./...strategy.matrix.includeandstrategy.matrix.exclude#630 and updatedmatrix_exclude_mismatchexpectations