Update popular_actions.go for actions/create-github-app-token@v3#668
Open
esaari wants to merge 1 commit into
Open
Update popular_actions.go for actions/create-github-app-token@v3#668esaari wants to merge 1 commit into
popular_actions.go for actions/create-github-app-token@v3#668esaari wants to merge 1 commit into
Conversation
The action's v3 action.yml added `client-id` as the canonical input,
deprecating `app-id`, and added several new inputs (`enterprise`,
`permission-artifact-metadata`, `permission-attestations`,
`permission-discussions`, `permission-merge-queues`).
The bundled v3 schema still marked `app-id` as required and did not
know about `client-id`, producing two false-positives per `with:` block
on workflows that use the canonical input:
- `missing input "app-id" which is required by action ...`
- `input "client-id" is not defined in action ...`
Regenerated via:
go run ./scripts/generate-popular-actions \
-r /tmp/single-entry-registry.json -q
against a single-entry registry containing only this slug (the full
default-registry regen currently fails on an unrelated 404 for a
deleted upstream tag — `actions-cool/issues-helper@v1`).
v1 and v2 entries were verified against their current action.yml and
left untouched — those tags ship `app-id` only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #669.
What
Regenerate the v3 entry in
popular_actions.goforactions/create-github-app-tokento match its current upstream
action.yml.Diff:
app-id— wasrequired: true; nowrequired: falsewithdeprecationMessage: "Use 'client-id' instead."client-id— added (canonical replacement forapp-id)enterprise— addedpermission-artifact-metadata— addedpermission-attestations— addedpermission-discussions— addedpermission-merge-queues— addedv1 and v2 schemas were verified against their respective live
action.ymlfilesand left untouched — those tags ship
app-idonly and don't need any change.Why
The bundled v3 schema still requires
app-idand doesn't know aboutclient-id.On any workflow using the canonical input, actionlint produces two false-positives
per
with:block:actions/create-github-app-token@v3was published 2025-09 withclient-idas thecanonical input; teams adopting the supported input get this false-positive pair
on every call site. Full repro and root cause in #669.
Generation method
I tried the full regen first
(
go run ./scripts/generate-popular-actions ./popular_actions.go),but it currently fails on an unrelated 404:
actions-cool/issues-helperappears to have moved/deleted itsv1tag upstream.This is also blocking the weekly auto-refresh workflow from updating any entry —
worth a follow-up to make the generator tolerant of upstream 404s, but out of
scope for this PR. I scoped the regen to just the affected action via a
single-entry registry:
(where
/tmp/cgat-registry.jsoncontains only theactions/create-github-app-tokenslug). The output was then patched into the existing
popular_actions.goin place.The resulting diff is byte-for-byte what the full regenerator would produce for
this entry — no manual edits to the generated formatting.
Verification
go build ./...— passgo test -run TestPopularActionsDataset ./...— passgo test ./...— pass