Skip to content

Commit 8aeaaf9

Browse files
committed
Make node 22 the minimum version
1 parent 46411d7 commit 8aeaaf9

5 files changed

Lines changed: 29 additions & 207 deletions

File tree

.github/workflows/push-checks.yaml

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,21 @@ jobs:
66
name: Verify that Docker can build
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v4
9+
- uses: actions/checkout@v6
1010
- name: Build the Dockerfile
1111
run: docker compose build
1212
openscad-node:
1313
name: Verify that OpenSCAD keycap scripts work (Node.js)
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v6
1717

18-
- uses: actions/setup-node@v4
18+
- uses: actions/setup-node@v6
1919
with:
20-
node-version: 21
21-
22-
- name: Just make npm work
23-
run: npm i @rollup/rollup-linux-x64-gnu
20+
node-version: 22
2421

2522
- name: Install npm dependencies
26-
run: npm install --omit=optional
23+
run: npm ci
2724

2825
- name: Install openscad
2926
run: sudo apt-get update && sudo apt-get install -y openscad
@@ -37,7 +34,7 @@ jobs:
3734
name: Verify that OpenSCAD keycap scripts work (Bun/Linux)
3835
runs-on: ubuntu-latest
3936
steps:
40-
- uses: actions/checkout@v4
37+
- uses: actions/checkout@v6
4138

4239
- uses: oven-sh/setup-bun@v2
4340
with:
@@ -59,7 +56,7 @@ jobs:
5956
# name: Verify Set up (Bun/Linux)
6057
# runs-on: ubuntu-latest
6158
# steps:
62-
# - uses: actions/checkout@v4
59+
# - uses: actions/checkout@v6
6360

6461
# - uses: oven-sh/setup-bun@v2
6562

@@ -71,7 +68,7 @@ jobs:
7168
# name: Verify Set up (Bun/Windows)
7269
# runs-on: windows-latest
7370
# steps:
74-
# - uses: actions/checkout@v4
71+
# - uses: actions/checkout@v6
7572

7673
# - uses: oven-sh/setup-bun@v1
7774
# with:
@@ -90,11 +87,11 @@ jobs:
9087
# name: Verify Set up (Node/Windows)
9188
# runs-on: windows-latest
9289
# steps:
93-
# - uses: actions/checkout@v4
90+
# - uses: actions/checkout@v6
9491

95-
# - uses: actions/setup-node@v4
92+
# - uses: actions/setup-node@v6
9693
# with:
97-
# node-version: 21
94+
# node-version: 24
9895

9996
# - name: Install npm dependencies
10097
# run: npm install

.nvmrc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
21.5
2-
1+
22

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ To run the generator locally, you have two options:
2727
1. **Recommended Setup**:
2828

2929
- [Clone] the repository and [install Bun][bun].
30-
> The rationale is that Bun has built-in TypeScript and path mapping support. Alternatively, you can use [Node.js][nodejs] v21 or later ([nvm][nvm-sh] recommended for Linux users). When using Node.js, Cosmos uses a custom ESM loader, which is more difficult to debug when things ultimately go wrong. Nevertheless, the WASM build scripts are more reliable in Node.js than Bun.
30+
> The rationale is that Bun has built-in TypeScript and path mapping support. Alternatively, you can use [Node.js][nodejs] v22 or later ([nvm][nvm-sh] recommended for Linux users). When using Node.js, Cosmos uses a custom ESM loader, which is more difficult to debug when things ultimately go wrong. Nevertheless, the WASM build scripts are more reliable in Node.js than Bun.
3131
- Run `make quickstart` to compile and build the necessary files.
3232
- Read the [dev documentation](https://ryanis.cool/cosmos/docs/contributing/#building-the-project) if you wish to compile the docs or create a production build.
3333
- Finally, run `make dev` to start a dev server and visit [`http://localhost:5173/beta`](http://localhost:5173/beta).

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# syntax=docker/dockerfile:1
2-
FROM node:21.5
2+
FROM node:22
33

44
ENV SKIP_MAKE_FILES=${SKIP_MAKE_FILES}
55

0 commit comments

Comments
 (0)