stopped grunt from executing during install#48
Open
trevorah wants to merge 1 commit into
Open
Conversation
|
yeah that is a show stopper. just used now a library that dependes on node-spritesheet and my installation failed cause i don't have grunt installed. not cool 👎 : ( |
|
yeah I agree |
|
Thank you for this @trevorah. I merged your changes into our branch, and it's working great! |
Author
|
No problem! On Fri, Sep 12, 2014 at 7:40 PM, Steven Xu notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating the
lib/*.jsjavascript from thesrc/*.coffeefiles during install, they are generated before this package is published. This means that installation is a little quicker and simpler for all users and is recommended by npm.As a bonus, grunt and its plugins are just dev dependencies. Also, unlike #40, the generated
lib/*.jsfiles do not need to be checked in.