Skip to content

Fix Firefox manifest warning for version_name property #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardkmichael merged 1 commit into from
Jan 9, 2026
Merged

Fix Firefox manifest warning for version_name property #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions BUILD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This extension maintains **separate manifest files** due to incompatible Manifes
"browser_specific_settings": {
"gecko": {
"id": "github-bookmarked-issues@extensions",
"strict_min_version": "128.0",
"strict_min_version": "142.0",
"data_collection_permissions": {"required": ["none"]}
}
}
Expand Down Expand Up @@ -168,7 +168,8 @@ The script outputs a `GITHUB_AUTH_STATE` value to add to `.env`. Sessions expire

### Version Tracking

Dev builds include git commit info in `version_name` (visible in `chrome://extensions` or `about:addons`):
Dev builds include git commit info in `version_name` (Chrome only, visible in `chrome://extensions`).
Firefox does not support `version_name`; it warns about unknown manifest properties at runtime.

| Build Type | version_name Example |
|----------------------------|-------------------------------------------|
Expand Down
2 changes: 1 addition & 1 deletion extension/manifest-firefox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"browser_specific_settings": {
"gecko": {
"id": "github-bookmarked-issues@extensions",
"strict_min_version": "128.0",
"strict_min_version": "142.0",
"data_collection_permissions": {
"required": ["none"]
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"build": "npm run build:chrome && npm run build:firefox",
"postbuild": "npm run lint",
"dev:watch": "node scripts/dev-watch.js",
"lint": "web-ext lint --source-dir=build/firefox --artifacts-dir=build",
"lint": "web-ext lint --source-dir=build/firefox --artifacts-dir=build --warnings-as-errors",
"test": "playwright test",
"test:chrome": "playwright test --project=chromium",
"test:visual": "playwright test --grep @visual",
Expand Down
5 changes: 4 additions & 1 deletion scripts/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ async function build() {

const versionName = getVersionName(manifest.version);
if (versionName !== manifest.version) {
manifest.version_name = versionName;
// version_name is Chrome-specific; Firefox warns about unknown properties
if (browser === 'chrome') {
manifest.version_name = versionName;
}
console.log(` Version: ${versionName}`);
}

Expand Down