remove the google() repository requirement from docs

The `google()` repository should no longer be mandatory, since AGP is no longer in the plugin's runtime classpath.

Author: RBusarow

build.gradle.kts

@@ -36,7 +36,6 @@ plugins {
   id("mcbuild.artifacts-check")
   id("mcbuild.ben-manes")
   id("mcbuild.clean")
-  id("mcbuild.dependency-guard")
   id("mcbuild.dokka")
   id("mcbuild.knit")
   id("mcbuild.kotlin")

modulecheck-gradle/plugin/src/test/kotlin/modulecheck/gradle/BaseGradleTest.kt

@@ -36,6 +36,7 @@ import org.junit.jupiter.api.DynamicTest
 import java.io.File
 import kotlin.text.RegexOption.IGNORE_CASE
 
+@Suppress("PropertyName")
 abstract class BaseGradleTest :
   BaseTest(),
   ProjectCollector,
@@ -52,62 +53,69 @@ abstract class BaseGradleTest :
   override val root: File
     get() = testProjectDir
 
+  val DEFAULT_BUILD_FILE by resets {
+    """
+    buildscript {
+      dependencies {
+        classpath("com.android.tools.build:gradle:$agpVersion")
+        classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion")
+      }
+    }
+
+    plugins {
+      id("com.rickbusarow.module-check")
+    }
+    """.trimIndent()
+  }
+
   val rootBuild by resets {
     root.child("build.gradle.kts")
-      .createSafely(
-        """
-        buildscript {
-          dependencies {
-            classpath("com.android.tools.build:gradle:$agpVersion")
-            classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion")
-          }
-        }
+      .createSafely(DEFAULT_BUILD_FILE)
+  }
+
+  val DEFAULT_SETTINGS_FILE by resets {
+    """
+    rootProject.name = "root"
 
-        plugins {
-          id("com.rickbusarow.module-check")
+    pluginManagement {
+      repositories {
+        gradlePluginPortal()
+        mavenCentral()
+        mavenLocal()
+        google()
+      }
+      resolutionStrategy {
+        eachPlugin {
+          if (requested.id.id.startsWith("com.android")) {
+            useVersion("$agpVersion")
+          }
+          if (requested.id.id == "com.rickbusarow.module-check") {
+            useVersion("${BuildProperties.VERSION}")
+          }
+          if (requested.id.id.startsWith("org.jetbrains.kotlin")) {
+            useVersion("$kotlinVersion")
+          }
+          if (requested.id.id == "com.squareup.anvil") {
+            useVersion("$anvilVersion")
+          }
         }
-        """.trimIndent()
-      )
+      }
+    }
+    dependencyResolutionManagement {
+      @Suppress("UnstableApiUsage")
+      repositories {
+        mavenCentral()
+        mavenLocal()
+        google()
+      }
+    }
+    """.trimIndent()
   }
+
   val rootSettings by resets {
     root.child("settings.gradle.kts")
       .createSafely(
-        """
-        rootProject.name = "root"
-
-        pluginManagement {
-          repositories {
-            gradlePluginPortal()
-            mavenCentral()
-            mavenLocal()
-            google()
-          }
-          resolutionStrategy {
-            eachPlugin {
-              if (requested.id.id.startsWith("com.android")) {
-                useVersion("$agpVersion")
-              }
-              if (requested.id.id == "com.rickbusarow.module-check") {
-                useVersion("${BuildProperties.VERSION}")
-              }
-              if (requested.id.id.startsWith("org.jetbrains.kotlin")) {
-                useVersion("$kotlinVersion")
-              }
-              if (requested.id.id == "com.squareup.anvil") {
-                useVersion("$anvilVersion")
-              }
-            }
-          }
-        }
-        dependencyResolutionManagement {
-          @Suppress("UnstableApiUsage")
-          repositories {
-            mavenCentral()
-            mavenLocal()
-            google()
-          }
-        }
-        """.trimIndent()
+        DEFAULT_SETTINGS_FILE
       )
   }
 

modulecheck-gradle/plugin/src/test/kotlin/modulecheck/gradle/RuntimeClasspathValidationTest.kt

@@ -16,6 +16,8 @@
 package modulecheck.gradle
 
 import io.kotest.matchers.string.shouldContain
+import modulecheck.gradle.internal.BuildProperties
+import modulecheck.utils.remove
 import org.junit.jupiter.api.TestFactory
 
 class RuntimeClasspathValidationTest : BaseGradleTest() {
@@ -52,6 +54,48 @@ class RuntimeClasspathValidationTest : BaseGradleTest() {
           }
           """
         )
+        // This is the same settings as the default used in other tests,
+        // except no `google()` repository.  `google()` shouldn't be necessary since there should be
+        // no dependency upon AGP.
+        rootSettings.writeText(
+          """
+          rootProject.name = "root"
+
+          pluginManagement {
+            repositories {
+              gradlePluginPortal()
+              mavenCentral()
+              mavenLocal()
+            }
+            resolutionStrategy {
+              eachPlugin {
+                if (requested.id.id.startsWith("com.android")) {
+                  useVersion("$agpVersion")
+                }
+                if (requested.id.id == "com.rickbusarow.module-check") {
+                  useVersion("${BuildProperties.VERSION}")
+                }
+                if (requested.id.id.startsWith("org.jetbrains.kotlin")) {
+                  useVersion("$kotlinVersion")
+                }
+                if (requested.id.id == "com.squareup.anvil") {
+                  useVersion("$anvilVersion")
+                }
+              }
+            }
+          }
+          dependencyResolutionManagement {
+            @Suppress("UnstableApiUsage")
+            repositories {
+              mavenCentral()
+              mavenLocal()
+            }
+          }
+          """.trimIndent()
+        )
+
+        // just double-check that this settings file is in sync with the default
+        rootSettings shouldHaveText DEFAULT_SETTINGS_FILE.remove("\\s*google\\(\\)".toRegex())
 
         shouldSucceed(taskName)
       }

website/docs/quickstart.mdx

@@ -25,8 +25,6 @@ values={[
 pluginManagement {
   repositories {
     gradlePluginPortal()
-    // used for Android Gradle Plugin internally
-    google()
     // Add for SNAPSHOT builds
     maven("https://oss.sonatype.org/content/repositories/snapshots/")
   }
@@ -51,8 +49,6 @@ plugins {
 pluginManagement {
   repositories {
     gradlePluginPortal()
-    // used for Android Gradle Plugin internally
-    google()
     // Add for SNAPSHOT builds
     maven {
       url "https://oss.sonatype.org/content/repositories/snapshots"