address Detekt changes

Author: RBusarow

build-logic/conventions/src/main/kotlin/modulecheck/builds/KotlinJvmConventionPlugin.kt

@@ -18,6 +18,7 @@ package modulecheck.builds
 import com.rickbusarow.kgx.applyOnce
 import com.rickbusarow.kgx.dependsOn
 import com.rickbusarow.kgx.javaExtension
+import com.rickbusarow.kgx.names.ConfigurationName
 import org.gradle.api.JavaVersion
 import org.gradle.api.Plugin
 import org.gradle.api.Project
@@ -48,6 +49,11 @@ abstract class KotlinJvmConventionPlugin : Plugin<Project> {
       extension.sourceCompatibility = JavaVersion.toVersion(target.JVM_TARGET)
     }
 
+    target.dependencies.add(
+      ConfigurationName.implementation.value,
+      target.dependencies.platform(target.libs.kotlin.bom)
+    )
+
     target.tasks.withType(KotlinCompile::class.java).configureEach { task ->
       task.kotlinOptions {
         allWarningsAsErrors = false

dependency-guard-aggregate.txt

@@ -25,7 +25,7 @@ changeTracker = "0.7.4"
 classgraph = "4.8.162"
 commons-io = "2.15.1"
 dependencyAnalysis = "1.20.0"
-detekt = "1.23.1"
+detekt = "1.23.4"
 diffplug-spotless = "6.24.0"
 dokka = "1.9.10"
 dropbox-dependencyGuard = "0.4.3"

gradle/libs.versions.toml

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -50,9 +50,10 @@ data class AnvilScopedDeclarations(
 
 /**
  * Represents a graph of Anvil scopes and their associated declarations.
- * @property project the [McProject] for which this graph is defined
- * @property delegate a cache that maps from [SourceSetName]
- *   to a map of [AnvilScopeName] to [AnvilScopedDeclarations]
+ *
+ * @param project the [McProject] for which this graph is defined
+ * @param delegate a cache that maps from [SourceSetName] to
+ *   a map of [AnvilScopeName] to [AnvilScopedDeclarations]
  */
 data class AnvilGraph(
   private val project: McProject,

modulecheck-api/src/main/kotlin/modulecheck/api/context/AnvilGraph.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -32,7 +32,7 @@ import java.io.File
  *
  * @property fileFactoryCache a cache for mapping source
  *   set names to corresponding JVM file providers
- * @property project the project for which the JVM files are needed
+ * @param project the project for which the JVM files are needed
  */
 data class JvmFiles(
   internal val fileFactoryCache: SafeCache<SourceSetName, JvmFileProvider>,

modulecheck-api/src/main/kotlin/modulecheck/api/context/JvmFiles.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -24,9 +24,9 @@ import java.io.File
 /**
  * All JVM source files for a specific source set in a project.
  *
- * @property delegate a [SafeCache] instance which manages a
- *   cache of source set names to the associated JVM source files.
- * @property project the [McProject] for which the source files are retrieved.
+ * @param delegate a [SafeCache] instance which manages a cache
+ *   of source set names to the associated JVM source files.
+ * @param project the [McProject] for which the source files are retrieved.
  */
 data class JvmSourceFiles(
   private val delegate: SafeCache<SourceSetName, Set<File>>,

modulecheck-api/src/main/kotlin/modulecheck/api/context/JvmSourceFiles.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -46,7 +46,7 @@ suspend fun McProject.uses(dependency: ConfiguredDependency): Boolean {
 private suspend fun <T> McProject.usesCodeGenDependency(
   dependency: T
 ): Boolean where T : ConfiguredDependency,
-      T : MightHaveCodeGeneratorBinding {
+                 T : MightHaveCodeGeneratorBinding {
 
   val codeGeneratorBinding = dependency.codeGeneratorBindingOrNull
     // If the dependency doesn't have a binding, default to treating it as used

modulecheck-api/src/main/kotlin/modulecheck/api/context/uses.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -28,9 +28,9 @@ import modulecheck.utils.mapToSet
 /**
  * Represents a data class that contains all unused Kapt processors in a project.
  *
- * @property delegate a [SafeCache] instance which manages a cache
- *   of configuration names to the associated unused Kapt processors.
- * @property project the [McProject] for which the unused Kapt processors are retrieved.
+ * @param delegate a [SafeCache] instance which manages a cache of
+ *   configuration names to the associated unused Kapt processors.
+ * @param project the [McProject] for which the unused Kapt processors are retrieved.
  */
 data class UnusedKaptProcessors(
   private val delegate: SafeCache<ConfigurationName, Set<UnusedKaptProcessorFinding>>,

modulecheck-core/src/main/kotlin/modulecheck/core/context/UnusedKaptProcessors.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2023 Rick Busarow
+ * Copyright (C) 2021-2024 Rick Busarow
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -45,9 +45,9 @@ import kotlin.LazyThreadSafetyMode.NONE
  * Factory for creating [AndroidPlatformPlugin] instances
  * based on the type of Android Gradle Plugin (AGP) extension.
  *
- * @property agpApiAccess Provides access to AGP APIs.
- * @property configurationsFactory Factory for creating [Configurations] instances.
- * @property sourceSetsFactory Factory for creating [SourceSets] instances.
+ * @param agpApiAccess Provides access to AGP APIs.
+ * @param configurationsFactory Factory for creating [Configurations] instances.
+ * @param sourceSetsFactory Factory for creating [SourceSets] instances.
  */
 @ContributesBinding(TaskScope::class)
 class RealAndroidPlatformPluginFactory @Inject constructor(