don't find must-be-api if the project is already an api dependency also

fixes #662

Author: RBusarow

modulecheck-core/src/main/kotlin/modulecheck/core/context/MustBeApi.kt

@@ -100,7 +100,7 @@ data class MustBeApi(
             .distinctBy { it.path }
             .filterNot { cpd ->
               // exclude anything which is inherited but already included in local `api` deps
-              cpd in directApiProjects
+              cpd.copy(configurationName = cpd.configurationName.apiVariant()) in directApiProjects
             }
             .filterAsync {
               !sourceSetName.isTestingOnly() && it.project(project.projectCache)

modulecheck-core/src/test/kotlin/modulecheck/core/MustBeApiTest.kt

@@ -643,6 +643,63 @@ class MustBeApiTest : RunnerTest() {
     logger.parsedReport() shouldBe listOf()
   }
 
+  @Test
+  fun `api and implementation of the same dependency with auto-correct should not be changed`() {
+
+    val lib1 = kotlinProject(":lib1") {
+      addKotlinSource(
+        """
+        package com.modulecheck.lib1
+
+        class Lib1Class
+        """
+      )
+    }
+
+    val lib2 = kotlinProject(":lib2") {
+      addDependency(ConfigurationName.api, lib1)
+      addDependency(ConfigurationName.implementation, lib1)
+
+      buildFile {
+        """
+        plugins {
+          kotlin("jvm")
+        }
+
+        dependencies {
+          api(project(path = ":lib1"))
+          implementation(project(path = ":lib1"))
+        }
+        """
+      }
+
+      addKotlinSource(
+        """
+        package com.modulecheck.lib2
+
+        import com.modulecheck.lib1.Lib1Class
+
+        val lib1Class = Lib1Class()
+        """
+      )
+    }
+
+    run().isSuccess shouldBe true
+
+    lib2.buildFile shouldHaveText """
+        plugins {
+          kotlin("jvm")
+        }
+
+        dependencies {
+          api(project(path = ":lib1"))
+          implementation(project(path = ":lib1"))
+        }
+    """
+
+    logger.parsedReport() shouldBe listOf()
+  }
+
   @Test
   fun `public property from dependency in test source should not require API`() {