feat: relative sizing of section on hero page#17
Merged
Conversation
|
Member
Author
|
@Mummanajagadeesh check if the relative sizing thing is fine now, test on mob as well as desktop versions, if anything else, I'll add to this PR itself |
There was a problem hiding this comment.
Pull request overview
Updates homepage section sizing and spacing to better match the visible viewport and improve anchor scrolling behavior.
Changes:
- Switched section/containers from
100vhto100dvhfor viewport-relative sizing. - Adjusted
.herospacing (padding-based navbar offset, explicit paddings) and added divider/border-box sizing. - Added
scroll-margin-topto sections (and adjusted mobile variant) to account for the fixed navbar.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/styles/main_projects.css | Updates projects container min-height to use dynamic viewport height. |
| src/styles/main_body.css | Adjusts hero + generic section sizing/layout, adds scroll offset for anchor navigation, and refines padding/border behavior. |
| src/styles/main_about.css | Updates about container min-height to use dynamic viewport height and removes the redundant top border. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| align-items: center; | ||
| gap: 20px; | ||
| min-height: 100vh; | ||
| min-height: 100dvh; |
| justify-content: space-between; | ||
| align-items: center; | ||
| min-height: 100vh; | ||
| min-height: 100dvh; |
| /* HERO (first section) */ | ||
| .hero { | ||
| margin-top: 120px; | ||
| min-height: 100dvh; |
| /* Section styling + dividers */ | ||
| section:not(#footer-new) { | ||
| min-height: 100vh; | ||
| min-height: 100dvh; |
| padding-left: 1rem; | ||
| padding-right: 1rem; | ||
| padding-bottom: 1.5rem; | ||
| min-height: 100dvh; |
| section:not(#footer-new) { | ||
| font-size: 1.8rem; | ||
| padding: 2rem 1rem; | ||
| min-height: 100dvh; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.