Tag-based filtering in dimensions/measures dropdown#9495
Open
nishantmonu51 wants to merge 3 commits into
Open
Conversation
Render the dimensions and measures dropdown as a two-column layout when any item has tags, with the tag list on the left and shown/hidden items on the right. Clicking a tag filters the right column; per-tag actions (only show, show all, hide all) are inline on each row. Without tags, the dropdown keeps its original single-column shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a chip-style `TagInput` to the dimension and measure edit sidebar so authors can manage tags without dropping into raw YAML. The input suggests existing tags from the same file via a portaled autocomplete that flips above the input when there isn't room below and clamps its max height to the available viewport space. Also adds `tags` to the metrics view JSON schema so the YAML editor stops flagging it as an unknown property. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address review feedback by collapsing the two parallel tag
implementations (inline in the dropdown vs. dead exports under
state-managers/{actions,selectors}/tags.ts) into a single pure module
at components/menu/tag-utils.ts. The dropdown now imports the helpers
directly, and the unused state-manager wiring is removed.
Tag strings are trimmed on read in both the dropdown's derivation and
the visual editor's YAML read path so accidental whitespace doesn't
create duplicate tags.
Add unit tests for the derivation, tri-state visibility, and the three
bulk actions (including the min-one invariant). Tighten the metrics
schema descriptions to mention the dashboard dropdown surface and the
trimming/case-sensitivity behavior.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tagsin its metrics view spec: tag list on the left, shown/hidden items on the right. Without tags, the dropdown keeps its original single-column shape.visible/totalcount. Click the row body to filter the right column to items in that tag. Three inline actions appear on hover: Only show this tag, Show all in tag, Hide all in tag.dimensionTags,dimensionTagVisibilityState,dimensionsForTagand the measure mirrors) and bulk actions live understate-managers/{selectors,actions}/tags.ts. No backend or proto changes — the per-itemtags: []stringfield is already parsed by the runtime today.setDimensionVisibility/setMeasureVisibilityflow.Checklist:
Developed in collaboration with Claude Code