Skip to content

Update FileUpload dependency to 2.0.0-M5#551

Merged
weavejester merged 1 commit intoring-clojure:masterfrom
miguno:commons-fileupload2-core-update
Apr 12, 2026
Merged

Update FileUpload dependency to 2.0.0-M5#551
weavejester merged 1 commit intoring-clojure:masterfrom
miguno:commons-fileupload2-core-update

Conversation

@miguno
Copy link
Copy Markdown
Contributor

@miguno miguno commented Apr 12, 2026

Thanks for your continued work on ring!

This PR updates org.apache.commons/commons-fileupload2-core to 2.0.0-M5 from Feb 17, 2026 to address a CVE in 2.0.0-M4.

Background: The currently used version 2.0.0-M4 of org.apache.commons/commons-fileupload2-core is, via its own dependencies, vulnerable to CVE-2025-48924 (StackOverflowError on very long inputs).

References:

@weavejester
Copy link
Copy Markdown
Member

It appears as if the API for setFileSizeMax has been changed between M4 and M5.

@weavejester
Copy link
Copy Markdown
Member

It looks like setFileSizeMax is now setMaxFileSize.

@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Apr 12, 2026

Updated the PR. Both lein test and lein test-all pass for me locally.

@weavejester
Copy link
Copy Markdown
Member

This also looks good! Can you squash down your commits into one? You can use your original commit message.

@miguno miguno force-pushed the commons-fileupload2-core-update branch from 05f981d to 0291c72 Compare April 12, 2026 17:40
@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Apr 12, 2026

Squashing done!

@weavejester
Copy link
Copy Markdown
Member

I don't think we need the second line of the commit message, since it's part of the update to 2.0.0-M5. So could you change the commit message to:

Update FileUpload dependency to 2.0.0-M5

This also ensures the commit message adheres to the contributing guidelines.

@miguno miguno force-pushed the commons-fileupload2-core-update branch from 0291c72 to b45404c Compare April 12, 2026 17:56
@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Apr 12, 2026

Done!

@weavejester weavejester merged commit a642e86 into ring-clojure:master Apr 12, 2026
1 check passed
@weavejester
Copy link
Copy Markdown
Member

Merged, thanks! When the other PR is merged, I'll cut a new patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants