Skip to content

test: add Management Mode service group coverage#101

Open
slingappa wants to merge 1 commit into
stack/slingapp_tests2/pr-10-performance-testsfrom
stack/slingapp_tests2/pr-11-management-mode-tests
Open

test: add Management Mode service group coverage#101
slingappa wants to merge 1 commit into
stack/slingapp_tests2/pr-10-performance-testsfrom
stack/slingapp_tests2/pr-11-management-mode-tests

Conversation

@slingappa

@slingappa slingappa commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

This PR adds Management Mode service-group test coverage.

Stack

Depends on: PR-10

Changes

  • Add Management Mode service-group tests for:
    • Notification unsupported behavior
    • Attribute reporting for MM shared memory
    • Registered-GUID communication
    • Callback-observed request/response shared-memory side effects
    • Short request rejection

Validation

  • make LIBRPMI_TEST=y CROSS_COMPILE= && make check CROSS_COMPILE=

Add a dedicated Management Mode test scenario and register it in the
test object list.

The scenario covers notification unsupported behavior, attribute
reporting for the MM shared-memory region, registered-GUID
communication, callback-observed shared-memory request and response
side effects, unknown GUID error handling, and short request rejection.

Signed-off-by: Subrahmanya Lingappa <subrahmanya.lingappa@qti.qualcomm.com>
Comment thread test/test_srvgrp_mm.c
@@ -0,0 +1,316 @@
// SPDX-License-Identifier: BSD-2-Clause
/*
* Copyright (c) 2024 Ventana Micro Systems Inc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year and Org are outdated

Comment thread test/test_srvgrp_mm.c
};

static enum rpmi_error test_mm_active_cb(struct rpmi_shmem *shmem,
rpmi_uint16_t req_datalen,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation looks out of sync here and several other places in the file below.

@saini-ranbirs saini-ranbirs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With commit 9836b30 integrated, please cross check the test cases execution wrt impact on expected response data length and value

Comment thread test/test_srvgrp_mm.c
.cleanup = test_scenario_default_cleanup,

.num_tests = 5,
.tests = {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following may be put inside separate struct if that helps to reduce indentation levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants