test: improve RPMI harness and expand BASE coverage#86
Conversation
slingappa
changed the title
slingappa
force-pushed
the
slingapp_tests2
branch
from
f030893 to
299397c
Compare
slingappa
changed the title
|
@avpatel @saini-ranbirs @pathakraul Please review |
|
@saini-ranbirs @avpatel @pathakraul Please review |
|
@saini-ranbirs @avpatel @pathakraul Please review |
|
@slingappa I tried reviewing yesterday but this is a large change set and unlike mailing list based review it is not straight forward to review each commit separately. My suggestion is that for Github based reviews please create more focused PRs and along these lines break down this PR into multiple PRs. The first PR should consist of only first two commits and subsequent PRs focused on separate service groups. Also, I think you can mark one PR to be depended on another PR. |
slingappa
force-pushed
the
slingapp_tests2
branch
from
299397c to
a120cfa
Compare
slingappa
changed the title
|
Thanks, agreed. I split the original PR into a stacked series of focused PRs. PR #86 now contains only the test harness improvement and BASE service-group coverage commits. The remaining changes are split into separate draft PRs by service group, with each PR based on the previous branch so the dependency chain is explicit and the diffs stay focused for review. Stack:
PR-2 through PR-11 are currently marked as draft to avoid accidental out-of-order merges, but they are available for parallel review. |
|
@avpatel please check, I've split the PR and posted them as stacked PRs, detailes are mentioned above also i those individual PRs. |
slingappa
force-pushed
the
slingapp_tests2
branch
from
a120cfa to
d7d0e51
Compare
Propagate per-test mismatches into scenario return status so make check fails when a comparison fails. Also copy request flags into the RPMI message header, verify ACK header identity for normal requests, and reject unexpected ACKs for posted requests. This makes the existing tests validate protocol behavior instead of only printing failures. Signed-off-by: Subrahmanya Lingappa <subrahmanya.lingappa@qti.qualcomm.com>
Add BASE probe coverage for unregistered, experimental, and vendor service group IDs, plus an invalid BASE service ID case. This complements the existing positive BASE service tests and relies on the shared harness ACK header checks to verify token, service group, and service ID mirroring for normal requests. Signed-off-by: Subrahmanya Lingappa <subrahmanya.lingappa@qti.qualcomm.com>
slingappa
force-pushed
the
slingapp_tests2
branch
from
d7d0e51 to
2abd540
Compare
|
Looks good to me. |
2 participants
This PR keeps the original PR #86 history while narrowing it to the RPMI test harness and BASE service-group coverage changes.
Stack
Changes
Validation
make LIBRPMI_TEST=y CROSS_COMPILE= && make check CROSS_COMPILE=