Skip to content

lib: clock: return SUCCESS when the operation is a no-op #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pathakraul merged 2 commits into from
Jun 25, 2026
Merged

lib: clock: return SUCCESS when the operation is a no-op #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebd764
lib: clock: return SUCCESS when the operation is a no-op
ch-perry May 14, 2026
91a3a84
lib: clock: refactor __rpmi_clock_set_state
ch-perry May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 13 additions & 44 deletions lib/rpmi_service_group_clock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ static enum rpmi_error __rpmi_clock_set_rate(struct rpmi_clock_group *clkgrp,
rate_change_req = clkgrp->ops->rate_change_match(clkgrp->ops_priv,
clk->id, rate);
if (!rate_change_req)
return RPMI_ERR_ALREADY;
return RPMI_SUCCESS;

ret = clkgrp->ops->set_rate(clkgrp->ops_priv, clk->id, match,
rate, &curr_rate);
Expand Down Expand Up @@ -197,35 +197,19 @@ static enum rpmi_error __rpmi_clock_set_state(struct rpmi_clock_group *clkgrp,
enum rpmi_error ret = 0;
struct rpmi_dlist *pos;

/**
* To disable a clock:
* - Must not be disabled already if its a leaf or independent clock.
* - If clock is a parent then all child clocks must be in disabled
* state already.
**/
if (state == RPMI_CLK_STATE_DISABLED) {
/* If clock already disabled? use the cached state */
if (clk->current_state == RPMI_CLK_STATE_DISABLED) {
return RPMI_ERR_ALREADY;
}
/* If the clock has no child or its a parent with single enable
* count then - disable, update cache and return */
if (!clk->child_count || clk->enable_count == 1) {
ret = clkgrp->ops->set_state(clkgrp->ops_priv,
clk->id, state);
if (ret)
return ret;

clk->current_state = state;
clk->enable_count -= 1;
goto done;
return RPMI_SUCCESS;
}

/* Check if all child clocks are disabled, otherwise deny */
rpmi_list_for_each(pos, &clk->child_clock) {
struct rpmi_clock *cc = to_rpmi_clock(pos);
if (cc->current_state == RPMI_CLK_STATE_ENABLED)
return RPMI_ERR_DENIED;
if (clk->child_count) {
rpmi_list_for_each(pos, &clk->child_clock) {
struct rpmi_clock *cc = to_rpmi_clock(pos);
if (cc->current_state == RPMI_CLK_STATE_ENABLED)
return RPMI_ERR_DENIED;
}
}

ret = clkgrp->ops->set_state(clkgrp->ops_priv, clk->id, state);
Expand All @@ -239,32 +223,18 @@ static enum rpmi_error __rpmi_clock_set_state(struct rpmi_clock_group *clkgrp,
* clock. Need to traverse the parents to check if the disable
* condition is met or not and disable if rules are met */
}
/**
* To enable a clock:
* - Must not be enabled already if its a independent clock
* - If a child clock(at any level in clock tree) then all its parent
* must be enabled.
*/
else if (state == RPMI_CLK_STATE_ENABLED) {
/* If clock is already enabled? use the cached state */
if (clk->current_state == RPMI_CLK_STATE_ENABLED)
return RPMI_ERR_ALREADY;
return RPMI_SUCCESS;

if (!clk->parent) {
ret = clkgrp->ops->set_state(clkgrp->ops_priv,
clk->id, state);
if (ret)
/* Enable all parents recursively up to the root */
if (clk->parent) {
ret = __rpmi_clock_set_state(clkgrp, clk->parent, state);
if (ret && ret != RPMI_ERR_ALREADY)
return ret;

clk->current_state = state;
clk->enable_count += 1;
goto done;
}

ret = __rpmi_clock_set_state(clkgrp, clk->parent, state);
if (ret && ret != RPMI_ERR_ALREADY)
return ret;

ret = clkgrp->ops->set_state(clkgrp->ops_priv, clk->id, state);
if (ret)
return ret;
Expand All @@ -273,7 +243,6 @@ static enum rpmi_error __rpmi_clock_set_state(struct rpmi_clock_group *clkgrp,
clk->enable_count += 1;
}

done:
return RPMI_SUCCESS;
}

Expand Down