fix: action log not saving - add timber logging for debug

Author: risunCode

app/src/main/java/com/appcontrolx/rollback/RollbackManager.kt

@@ -4,6 +4,7 @@ import android.content.Context
 import com.appcontrolx.executor.CommandExecutor
 import com.google.gson.Gson
 import com.google.gson.reflect.TypeToken
+import timber.log.Timber
 import java.io.File
 import java.util.UUID
 
@@ -16,6 +17,10 @@ class RollbackManager(
     private val snapshotFile = File(snapshotDir, "rollback_snapshot.json")
     private val historyFile = File(snapshotDir, "action_history.json")
 
+    init {
+        Timber.d("RollbackManager initialized, historyFile: ${historyFile.absolutePath}")
+    }
+    
     fun saveSnapshot(packages: List<String>): StateSnapshot {
         val states = packages.map { pkg ->
             val bgStatus = executor.execute("appops get $pkg RUN_IN_BACKGROUND")
@@ -68,20 +73,35 @@ class RollbackManager(
     }
 
     fun logAction(action: ActionLog) {
-        val history = getActionHistory().toMutableList()
-        history.add(0, action) // Add to beginning
-        
-        // Keep only last 100 actions
-        val trimmed = history.take(100)
-        historyFile.writeText(gson.toJson(trimmed))
+        try {
+            Timber.d("Logging action: ${action.action} for ${action.packages.size} packages")
+            val history = getActionHistory().toMutableList()
+            history.add(0, action) // Add to beginning
+            
+            // Keep only last 100 actions
+            val trimmed = history.take(100)
+            val json = gson.toJson(trimmed)
+            historyFile.writeText(json)
+            Timber.d("Action logged successfully, total logs: ${trimmed.size}")
+        } catch (e: Exception) {
+            Timber.e(e, "Failed to log action: ${action.action}")
+        }
     }
 
     fun getActionHistory(): List<ActionLog> {
-        if (!historyFile.exists()) return emptyList()
+        if (!historyFile.exists()) {
+            Timber.d("History file does not exist")
+            return emptyList()
+        }
         return try {
+            val content = historyFile.readText()
+            Timber.d("Reading history file, size: ${content.length} bytes")
             val type = object : TypeToken<List<ActionLog>>() {}.type
-            gson.fromJson(historyFile.readText(), type) ?: emptyList()
+            val logs: List<ActionLog>? = gson.fromJson(content, type)
+            Timber.d("Parsed ${logs?.size ?: 0} logs")
+            logs ?: emptyList()
         } catch (e: Exception) {
+            Timber.e(e, "Failed to read action history")
             emptyList()
         }
     }

app/src/main/java/com/appcontrolx/ui/AppDetailBottomSheet.kt

@@ -313,16 +313,20 @@ class AppDetailBottomSheet : BottomSheetDialogFragment() {
                 val result = withContext(Dispatchers.IO) { action() }
                 val success = result?.isSuccess == true
 
-                // Log action
-                if (logActionName != null && appInfo != null) {
+                // Log action - always log for all action types
+                if (appInfo != null && rollbackManager != null) {
+                    val finalLogAction = logActionName ?: actionName.uppercase().replace(" ", "_")
                     withContext(Dispatchers.IO) {
-                        rollbackManager?.logAction(ActionLog(
-                            action = logActionName,
+                        timber.log.Timber.d("Manual action: $finalLogAction, success=$success")
+                        rollbackManager!!.logAction(ActionLog(
+                            action = finalLogAction,
                             packages = listOf(appInfo!!.packageName),
                             success = success,
                             message = if (success) null else "Failed"
                         ))
                     }
+                } else {
+                    timber.log.Timber.w("Cannot log: appInfo=${appInfo != null}, rm=${rollbackManager != null}")
                 }
 
                 if (success) {
@@ -365,15 +369,18 @@ class AppDetailBottomSheet : BottomSheetDialogFragment() {
                 val success = result?.isSuccess == true
 
                 // Log action
-                if (appInfo != null) {
+                if (appInfo != null && rollbackManager != null) {
                     withContext(Dispatchers.IO) {
-                        rollbackManager?.logAction(ActionLog(
+                        timber.log.Timber.d("Background action: $logActionName, success=$success")
+                        rollbackManager!!.logAction(ActionLog(
                             action = logActionName,
                             packages = listOf(appInfo!!.packageName),
                             success = success,
                             message = if (success) null else "Failed"
                         ))
                     }
+                } else {
+                    timber.log.Timber.w("Cannot log bg action: appInfo=${appInfo != null}, rm=${rollbackManager != null}")
                 }
 
                 if (success) {

app/src/main/java/com/appcontrolx/ui/AppListFragment.kt

@@ -417,15 +417,20 @@ class AppListFragment : Fragment() {
                     }
                 }
             },
-            onComplete = { _, failCount ->
-                // Log action
-                lifecycleScope.launch(Dispatchers.IO) {
-                    rm?.logAction(ActionLog(
-                        action = action.name,
-                        packages = packages,
-                        success = failCount == 0,
-                        message = if (failCount == 0) null else "$failCount failed"
-                    ))
+            onComplete = { successCount, failCount ->
+                // Log action - always log regardless of action type
+                if (rm != null) {
+                    lifecycleScope.launch(Dispatchers.IO) {
+                        timber.log.Timber.d("Batch complete: ${action.name}, success=$successCount, fail=$failCount")
+                        rm.logAction(ActionLog(
+                            action = action.name,
+                            packages = packages,
+                            success = failCount == 0,
+                            message = if (failCount == 0) "All $successCount succeeded" else "$failCount failed"
+                        ))
+                    }
+                } else {
+                    timber.log.Timber.w("RollbackManager is null, cannot log action")
                 }
 
                 adapter.deselectAll()