refactor: rename list property methods to match rive-react API

Author: mfazekas

android/src/main/java/com/margelo/nitro/rive/HybridViewModelListProperty.kt

@@ -18,33 +18,36 @@ class HybridViewModelListProperty(private val listProperty: ViewModelListPropert
       ?: throw IllegalArgumentException("Expected HybridViewModelInstance but got ${instance::class.simpleName}")
   }
 
-  override fun instanceAt(index: Double): HybridViewModelInstanceSpec? {
+  override fun getInstanceAt(index: Double): HybridViewModelInstanceSpec? {
     val idx = index.toInt()
     if (idx < 0 || idx >= listProperty.size) return null
     return HybridViewModelInstance(listProperty.elementAt(idx))
   }
 
-  override fun append(instance: HybridViewModelInstanceSpec) {
+  override fun addInstance(instance: HybridViewModelInstanceSpec) {
     val hybridInstance = requireHybridInstance(instance)
     listProperty.add(hybridInstance.viewModelInstance)
   }
 
-  override fun insert(instance: HybridViewModelInstanceSpec, index: Double) {
+  override fun addInstanceAt(instance: HybridViewModelInstanceSpec, index: Double): Boolean {
     val hybridInstance = requireHybridInstance(instance)
-    listProperty.add(index.toInt(), hybridInstance.viewModelInstance)
+    val idx = index.toInt()
+    if (idx < 0 || idx > listProperty.size) return false
+    listProperty.add(idx, hybridInstance.viewModelInstance)
+    return true
   }
 
-  override fun remove(instance: HybridViewModelInstanceSpec) {
+  override fun removeInstance(instance: HybridViewModelInstanceSpec) {
     val hybridInstance = requireHybridInstance(instance)
     listProperty.remove(hybridInstance.viewModelInstance)
   }
 
-  override fun removeAt(index: Double) {
+  override fun removeInstanceAt(index: Double) {
     listProperty.removeAt(index.toInt())
   }
 
-  override fun swap(index1: Double, index2: Double) {
-    listProperty.swap(index1.toInt(), index2.toInt())
+  override fun swap(index1: Double, index2: Double): Boolean {
+    return listProperty.swap(index1.toInt(), index2.toInt())
   }
 
   override fun addListener(onChanged: () -> Unit) {

example/src/pages/DataBindingListExample.tsx

@@ -91,21 +91,21 @@ function ListExample({
     if (stringProp) {
       stringProp.value = 'new btn';
     }
-    listProperty.append(newInstance);
+    listProperty.addInstance(newInstance);
     riveRef.current?.playIfNeeded();
     refreshLength();
   }, [listProperty, file, refreshLength]);
 
   const handleRemoveFirst = useCallback(() => {
     if (!listProperty || listProperty.length === 0) return;
-    listProperty.removeAt(0);
+    listProperty.removeInstanceAt(0);
     riveRef.current?.playIfNeeded();
     refreshLength();
   }, [listProperty, refreshLength]);
 
   const handleRemoveLast = useCallback(() => {
     if (!listProperty || listProperty.length === 0) return;
-    listProperty.removeAt(listProperty.length - 1);
+    listProperty.removeInstanceAt(listProperty.length - 1);
     riveRef.current?.playIfNeeded();
     refreshLength();
   }, [listProperty, refreshLength]);
@@ -121,7 +121,7 @@ function ListExample({
     if (!listProperty) return;
     console.log(`List has ${listProperty.length} items:`);
     for (let i = 0; i < listProperty.length; i++) {
-      const item = listProperty.instanceAt(i);
+      const item = listProperty.getInstanceAt(i);
       console.log(`  [${i}]: ${item?.instanceName ?? 'undefined'}`);
     }
   }, [listProperty]);

ios/HybridViewModelListProperty.swift

@@ -13,7 +13,7 @@ class HybridViewModelListProperty: HybridViewModelListPropertySpec, ValuedProper
     Double(property.count)
   }
 
-  func instanceAt(index: Double) throws -> (any HybridViewModelInstanceSpec)? {
+  func getInstanceAt(index: Double) throws -> (any HybridViewModelInstanceSpec)? {
     guard let instance = property.instance(at: Int32(index)) else { return nil }
     return HybridViewModelInstance(viewModelInstance: instance)
   }
@@ -27,27 +27,27 @@ class HybridViewModelListProperty: HybridViewModelListPropertySpec, ValuedProper
     return viewModelInstance
   }
 
-  func append(instance: any HybridViewModelInstanceSpec) throws {
+  func addInstance(instance: any HybridViewModelInstanceSpec) throws {
     let viewModelInstance = try requireViewModelInstance(instance)
     property.append(viewModelInstance)
   }
 
-  func insert(instance: any HybridViewModelInstanceSpec, index: Double) throws {
+  func addInstanceAt(instance: any HybridViewModelInstanceSpec, index: Double) throws -> Bool {
     let viewModelInstance = try requireViewModelInstance(instance)
-    _ = property.insert(viewModelInstance, at: Int32(index))
+    return property.insert(viewModelInstance, at: Int32(index))
   }
 
-  func remove(instance: any HybridViewModelInstanceSpec) throws {
+  func removeInstance(instance: any HybridViewModelInstanceSpec) throws {
     let viewModelInstance = try requireViewModelInstance(instance)
     property.remove(viewModelInstance)
   }
 
-  func removeAt(index: Double) throws {
+  func removeInstanceAt(index: Double) throws {
     property.remove(at: Int32(index))
   }
 
-  func swap(index1: Double, index2: Double) throws {
-    property.swap(at: UInt32(index1), with: UInt32(index2))
+  func swap(index1: Double, index2: Double) throws -> Bool {
+    return property.swap(at: UInt32(index1), with: UInt32(index2))
   }
 
   func addListener(onChanged: @escaping () -> Void) throws {