feat: add SwiftLint and ktlint for native code linting (#54)

- Add SwiftLint CI job (runs on Ubuntu)
- Add ktlint CI job (runs on Ubuntu)
- Add local lint scripts: yarn lint:swift, yarn lint:kotlin, yarn lint:native
- Auto-fix minor style issues in Swift and Kotlin code

Author: mfazekas

.editorconfig

@@ -13,3 +13,22 @@ end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
+
+[*.kt]
+indent_size = 2
+max_line_length = 140
+ktlint_standard_no-wildcard-imports = disabled
+ktlint_standard_filename = disabled
+ktlint_standard_package-name = disabled
+ktlint_standard_indent = disabled
+ktlint_standard_function-signature = disabled
+ktlint_standard_class-signature = disabled
+ktlint_standard_multiline-expression-wrapping = disabled
+ktlint_standard_function-expression-body = disabled
+ktlint_standard_trailing-comma-on-call-site = disabled
+ktlint_standard_trailing-comma-on-declaration-site = disabled
+ktlint_standard_blank-line-before-declaration = disabled
+ktlint_standard_import-ordering = disabled
+ktlint_standard_string-template-indent = disabled
+ktlint_standard_backing-property-naming = disabled
+ktlint_standard_no-consecutive-comments = disabled

.github/workflows/ci.yml

@@ -11,6 +11,31 @@ on:
       - checks_requested
 
 jobs:
+  lint-swift:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: SwiftLint
+        uses: norio-nomura/action-swiftlint@3.2.1
+        with:
+          args: --config .swiftlint.yml
+
+  lint-kotlin:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: ktlint
+        uses: ScaCap/action-ktlint@master
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-review
+          ktlint_version: "1.5.0"
+          android: true
+
   lint:
     runs-on: ubuntu-latest
     steps:

.gitignore

@@ -83,3 +83,6 @@ lib/
 # React Native Codegen
 ios/generated
 android/generated
+
+# ktlint binary cache
+.ktlint/

.swiftlint.yml

@@ -0,0 +1,22 @@
+included:
+  - ios
+
+excluded:
+  - Pods
+  - nitrogen/generated
+
+disabled_rules:
+  - line_length
+  - file_length
+  - type_body_length
+  - function_body_length
+  - cyclomatic_complexity
+  - identifier_name
+  - force_cast
+  - force_try
+  - nesting
+  - trailing_whitespace
+  - todo
+  - unused_optional_binding
+
+reporter: github-actions-logging

android/src/main/java/com/margelo/nitro/rive/HybridRiveFile.kt

@@ -25,12 +25,12 @@ class HybridRiveFile : HybridRiveFileSpec() {
     get() = riveFile?.viewModelCount?.toDouble()
 
   override fun viewModelByIndex(index: Double): HybridViewModelSpec? {
-    val vm = riveFile?.getViewModelByIndex(index.toInt()) ?: return null;
+    val vm = riveFile?.getViewModelByIndex(index.toInt()) ?: return null
     return HybridViewModel(vm)
   }
 
   override fun viewModelByName(name: String): HybridViewModelSpec? {
-    val vm = riveFile?.getViewModelByName(name) ?: return null;
+    val vm = riveFile?.getViewModelByName(name) ?: return null
     return HybridViewModel(vm)
   }
 

android/src/main/java/com/margelo/nitro/rive/HybridRiveFileFactory.kt

@@ -133,4 +133,3 @@ class HybridRiveFileFactory : HybridRiveFileFactorySpec() {
     }
   }
 }
-

android/src/main/java/com/margelo/nitro/rive/HybridRiveView.kt

@@ -103,7 +103,7 @@ class HybridRiveView(val context: ThemedReactContext) : HybridRiveViewSpec() {
 
   override fun bindViewModelInstance(viewModelInstance: HybridViewModelInstanceSpec) =
     executeOnUiThread {
-      val hybridVmi = viewModelInstance as? HybridViewModelInstance ?: return@executeOnUiThread;
+      val hybridVmi = viewModelInstance as? HybridViewModelInstance ?: return@executeOnUiThread
       view.bindViewModelInstance(hybridVmi.viewModelInstance)
     }
 
@@ -147,7 +147,6 @@ class HybridRiveView(val context: ThemedReactContext) : HybridRiveViewSpec() {
     afterUpdate()
   }
 
-
   override fun afterUpdate() {
     logged(TAG, "afterUpdate") {
       val hybridFile = file as? HybridRiveFile
@@ -163,7 +162,7 @@ class HybridRiveView(val context: ThemedReactContext) : HybridRiveViewSpec() {
         layoutScaleFactor = layoutScaleFactor?.toFloat() ?: DefaultConfiguration.LAYOUTSCALEFACTOR,
         bindData = dataBind.toBindData()
       )
-      view.configure(config, dataBindingChanged=dataBindingChanged, needsReload, initialUpdate= initialUpdate)
+      view.configure(config, dataBindingChanged = dataBindingChanged, needsReload, initialUpdate = initialUpdate)
 
       if (needsReload && hybridFile != null) {
         hybridFile.registerView(this)
@@ -187,7 +186,7 @@ class HybridRiveView(val context: ThemedReactContext) : HybridRiveViewSpec() {
   }
 
   private fun executeOnUiThread(action: () -> Unit) {
-    context.currentActivity?.runOnUiThread() {
+    context.currentActivity?.runOnUiThread {
       try {
         action()
       } catch (e: Exception) {

android/src/main/java/com/margelo/nitro/rive/HybridViewModel.kt

@@ -18,7 +18,7 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
   override fun createInstanceByIndex(index: Double): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createInstanceFromIndex(index.toInt())
-      return HybridViewModelInstance(vmi);
+      return HybridViewModelInstance(vmi)
     } catch (e: ViewModelException) {
       return null
     }
@@ -27,7 +27,7 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
   override fun createInstanceByName(name: String): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createInstanceFromName(name)
-      return HybridViewModelInstance(vmi);
+      return HybridViewModelInstance(vmi)
     } catch (e: ViewModelException) {
       return null
     }
@@ -36,7 +36,7 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
   override fun createDefaultInstance(): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createDefaultInstance()
-      return HybridViewModelInstance(vmi);
+      return HybridViewModelInstance(vmi)
     } catch (e: ViewModelException) {
       return null
     }
@@ -45,7 +45,7 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
   override fun createInstance(): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createBlankInstance()
-      return HybridViewModelInstance(vmi);
+      return HybridViewModelInstance(vmi)
     } catch (e: ViewModelException) {
       return null
     }

android/src/main/java/com/rive/RiveReactNativeView.kt

@@ -19,7 +19,6 @@ import app.rive.runtime.kotlin.core.SMIInput
 import app.rive.runtime.kotlin.core.SMINumber
 import app.rive.runtime.kotlin.core.ViewModelInstance
 import app.rive.runtime.kotlin.core.errors.ViewModelException
-import com.margelo.nitro.core.AnyMap
 import com.margelo.nitro.rive.EventPropertiesOutput
 import com.margelo.nitro.rive.EventPropertiesOutputExtensions as EPO
 import com.margelo.nitro.rive.RiveEventType
@@ -187,7 +186,7 @@ class RiveReactNativeView(context: ThemedReactContext) : FrameLayout(context) {
 
   fun play() = riveAnimationView?.play()
 
-  fun pause() = riveAnimationView?.pause();
+  fun pause() = riveAnimationView?.pause()
 
   fun addEventListener(onEvent: (event: RNEvent) -> Unit) {
     val eventListener = object : RiveFileController.RiveEventListener {
@@ -329,7 +328,7 @@ class RiveReactNativeView(context: ThemedReactContext) : FrameLayout(context) {
       }
     }
 
-    return newMap;
+    return newMap
   }
 
   /**

ios/HybridRiveFile.swift

@@ -2,7 +2,7 @@ import RiveRuntime
 
 typealias ReferencedAssetCache = [String: RiveFileAsset]
 
-class HybridRiveFile: HybridRiveFileSpec, RiveViewSource  {
+class HybridRiveFile: HybridRiveFileSpec, RiveViewSource {
   var riveFile: RiveFile?
   var referencedAssetCache: ReferencedAssetCache?
   var assetLoader: ReferencedAssetLoader?