Skip to content

Commit 96787de

Browse files
mfazekasclaude
andcommitted
fix(ios): correct set(value:) argument label to match generated protocol
Nitrogen generates `func set(value: T)` with an external `value:` label, but our implementations had `func set(_ value: T)` with no external label. Fixes Swift build error: "instance method 'set' has different argument labels from those required by protocol 'Hybrid*PropertySpec_protocol' ('set(value:)')". Also updates the deprecated `value` setter delegate to `try? set(value: newValue)`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3ddd1aa commit 96787de

10 files changed

Lines changed: 30 additions & 30 deletions

ios/legacy/HybridViewModelBooleanProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class HybridViewModelBooleanProperty: HybridViewModelBooleanPropertySpec, Valued
1010
super.init()
1111
}
1212

13-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
13+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1414
var value: Bool {
1515
get { return property.value }
16-
set { set(newValue) }
16+
set { try? set(value: newValue) }
1717
}
1818

19-
func set(_ value: Bool) throws {
19+
func set(value: Bool) throws {
2020
property.value = value
2121
}
2222

ios/legacy/HybridViewModelColorProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class HybridViewModelColorProperty: HybridViewModelColorPropertySpec, ValuedProp
1010
super.init()
1111
}
1212

13-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
13+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1414
var value: Double {
1515
get { return property.value.toHexDouble() }
16-
set { set(newValue) }
16+
set { try? set(value: newValue) }
1717
}
1818

19-
func set(_ value: Double) throws {
19+
func set(value: Double) throws {
2020
property.value = UIColor(argb: Int(value))
2121
}
2222

ios/legacy/HybridViewModelEnumProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class HybridViewModelEnumProperty: HybridViewModelEnumPropertySpec, ValuedProper
1010
super.init()
1111
}
1212

13-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
13+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1414
var value: String {
1515
get { return property.value }
16-
set { set(newValue) }
16+
set { try? set(value: newValue) }
1717
}
1818

19-
func set(_ value: String) throws {
19+
func set(value: String) throws {
2020
property.value = value
2121
}
2222

ios/legacy/HybridViewModelNumberProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class HybridViewModelNumberProperty: HybridViewModelNumberPropertySpec, ValuedPr
1010
super.init()
1111
}
1212

13-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
13+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1414
var value: Double {
1515
get { return Double(property.value) }
16-
set { set(newValue) }
16+
set { try? set(value: newValue) }
1717
}
1818

19-
func set(_ value: Double) throws {
19+
func set(value: Double) throws {
2020
property.value = Float(value)
2121
}
2222

ios/legacy/HybridViewModelStringProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ class HybridViewModelStringProperty: HybridViewModelStringPropertySpec, ValuedPr
1010
super.init()
1111
}
1212

13-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
13+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1414
var value: String {
1515
get { return property.value }
16-
set { set(newValue) }
16+
set { try? set(value: newValue) }
1717
}
1818

19-
func set(_ value: String) throws {
19+
func set(value: String) throws {
2020
property.value = value
2121
}
2222

ios/new/HybridViewModelBooleanProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class HybridViewModelBooleanProperty: HybridViewModelBooleanPropertySpec {
1212
super.init()
1313
}
1414

15-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
15+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1616
var value: Bool {
1717
get {
1818
do {
@@ -22,10 +22,10 @@ class HybridViewModelBooleanProperty: HybridViewModelBooleanPropertySpec {
2222
return false
2323
}
2424
}
25-
set { set(newValue) }
25+
set { try? set(value: newValue) }
2626
}
2727

28-
func set(_ value: Bool) throws {
28+
func set(value: Bool) throws {
2929
let inst = instance
3030
let p = prop
3131
Task { @MainActor in

ios/new/HybridViewModelColorProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class HybridViewModelColorProperty: HybridViewModelColorPropertySpec {
1717
return Double(color.argbValue)
1818
}
1919

20-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
20+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
2121
var value: Double {
2222
get {
2323
do {
@@ -27,10 +27,10 @@ class HybridViewModelColorProperty: HybridViewModelColorPropertySpec {
2727
return 0
2828
}
2929
}
30-
set { set(newValue) }
30+
set { try? set(value: newValue) }
3131
}
3232

33-
func set(_ value: Double) throws {
33+
func set(value: Double) throws {
3434
let color = Color(UInt32(bitPattern: Int32(value)))
3535
let inst = instance
3636
let p = prop

ios/new/HybridViewModelEnumProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class HybridViewModelEnumProperty: HybridViewModelEnumPropertySpec {
1212
super.init()
1313
}
1414

15-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
15+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1616
var value: String {
1717
get {
1818
do {
@@ -22,10 +22,10 @@ class HybridViewModelEnumProperty: HybridViewModelEnumPropertySpec {
2222
return ""
2323
}
2424
}
25-
set { set(newValue) }
25+
set { try? set(value: newValue) }
2626
}
2727

28-
func set(_ value: String) throws {
28+
func set(value: String) throws {
2929
let inst = instance
3030
let p = prop
3131
Task { @MainActor in

ios/new/HybridViewModelNumberProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class HybridViewModelNumberProperty: HybridViewModelNumberPropertySpec {
1212
super.init()
1313
}
1414

15-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
15+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1616
var value: Double {
1717
get {
1818
do {
@@ -22,10 +22,10 @@ class HybridViewModelNumberProperty: HybridViewModelNumberPropertySpec {
2222
return 0
2323
}
2424
}
25-
set { set(newValue) }
25+
set { try? set(value: newValue) }
2626
}
2727

28-
func set(_ value: Double) throws {
28+
func set(value: Double) throws {
2929
let inst = instance
3030
let p = prop
3131
let v = Float(value)

ios/new/HybridViewModelStringProperty.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class HybridViewModelStringProperty: HybridViewModelStringPropertySpec {
1212
super.init()
1313
}
1414

15-
// Deprecated: Use getValueAsync (read) or set(_:) (write) instead
15+
// Deprecated: Use getValueAsync (read) or set(value:) (write) instead
1616
var value: String {
1717
get {
1818
do {
@@ -22,10 +22,10 @@ class HybridViewModelStringProperty: HybridViewModelStringPropertySpec {
2222
return ""
2323
}
2424
}
25-
set { set(newValue) }
25+
set { try? set(value: newValue) }
2626
}
2727

28-
func set(_ value: String) throws {
28+
func set(value: String) throws {
2929
let inst = instance
3030
let p = prop
3131
Task { @MainActor in

0 commit comments

Comments
 (0)