refactor: rename list property methods to match iOS SDK and react-hook-form

- addInstance -> append
- insertInstance -> insert
- removeInstance -> remove
- removeInstanceAt -> removeAt

Author: mfazekas

android/src/main/java/com/margelo/nitro/rive/HybridViewModelListProperty.kt

@@ -24,22 +24,22 @@ class HybridViewModelListProperty(private val listProperty: ViewModelListPropert
     return HybridViewModelInstance(listProperty.elementAt(idx))
   }
 
-  override fun addInstance(instance: HybridViewModelInstanceSpec) {
+  override fun append(instance: HybridViewModelInstanceSpec) {
     val hybridInstance = requireHybridInstance(instance)
     listProperty.add(hybridInstance.viewModelInstance)
   }
 
-  override fun insertInstance(instance: HybridViewModelInstanceSpec, index: Double) {
+  override fun insert(instance: HybridViewModelInstanceSpec, index: Double) {
     val hybridInstance = requireHybridInstance(instance)
     listProperty.add(index.toInt(), hybridInstance.viewModelInstance)
   }
 
-  override fun removeInstance(instance: HybridViewModelInstanceSpec) {
+  override fun remove(instance: HybridViewModelInstanceSpec) {
     val hybridInstance = requireHybridInstance(instance)
     listProperty.remove(hybridInstance.viewModelInstance)
   }
 
-  override fun removeInstanceAt(index: Double) {
+  override fun removeAt(index: Double) {
     listProperty.removeAt(index.toInt())
   }
 

example/src/pages/DataBindingListExample.tsx

@@ -63,7 +63,7 @@ function ListExample({
   instance: ViewModelInstance;
   file: RiveFile;
 }) {
-  const riveRef = useRef<RiveViewRef>(undefined);
+  const riveRef = useRef<RiveViewRef>(null);
   const [isPlaying, setIsPlaying] = useState(true);
   const listProperty = useMemo(
     () => instance.listProperty('ListItemVM'),
@@ -91,19 +91,19 @@ function ListExample({
     if (stringProp) {
       stringProp.value = 'new btn';
     }
-    listProperty.addInstance(newInstance);
+    listProperty.append(newInstance);
     refreshLength();
   }, [listProperty, file, refreshLength]);
 
   const handleRemoveFirst = useCallback(() => {
     if (!listProperty || listProperty.length === 0) return;
-    listProperty.removeInstanceAt(0);
+    listProperty.removeAt(0);
     refreshLength();
   }, [listProperty, refreshLength]);
 
   const handleRemoveLast = useCallback(() => {
     if (!listProperty || listProperty.length === 0) return;
-    listProperty.removeInstanceAt(listProperty.length - 1);
+    listProperty.removeAt(listProperty.length - 1);
     refreshLength();
   }, [listProperty, refreshLength]);
 

ios/HybridViewModelListProperty.swift

@@ -31,22 +31,22 @@ class HybridViewModelListProperty: HybridViewModelListPropertySpec, ValuedProper
     return viewModelInstance
   }
 
-  func addInstance(instance: any HybridViewModelInstanceSpec) throws {
+  func append(instance: any HybridViewModelInstanceSpec) throws {
     let viewModelInstance = try requireViewModelInstance(instance)
     property.append(viewModelInstance)
   }
 
-  func insertInstance(instance: any HybridViewModelInstanceSpec, index: Double) throws {
+  func insert(instance: any HybridViewModelInstanceSpec, index: Double) throws {
     let viewModelInstance = try requireViewModelInstance(instance)
     _ = property.insert(viewModelInstance, at: Int32(index))
   }
 
-  func removeInstance(instance: any HybridViewModelInstanceSpec) throws {
+  func remove(instance: any HybridViewModelInstanceSpec) throws {
     let viewModelInstance = try requireViewModelInstance(instance)
     property.remove(viewModelInstance)
   }
 
-  func removeInstanceAt(index: Double) throws {
+  func removeAt(index: Double) throws {
     property.remove(at: Int32(index))
   }