Skip to content

Commit fecb765

Browse files
mfazekasclaudehappy-otter
committed
fix: resolve typecheck errors in databinding-advanced harness tests
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
1 parent 6adf1f4 commit fecb765

1 file changed

Lines changed: 7 additions & 13 deletions

File tree

example/__tests__/databinding-advanced.harness.ts

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import { describe, it, expect } from 'react-native-harness';
2-
import type { ViewModelInstance } from '@rive-app/react-native';
2+
import type {
3+
ViewModelInstance,
4+
ViewModelStringProperty,
5+
} from '@rive-app/react-native';
36
import { RiveFileFactory } from '@rive-app/react-native';
47

58
const DATABINDING = require('../assets/rive/databinding.riv');
@@ -15,15 +18,6 @@ async function loadFile(source: number) {
1518
return RiveFileFactory.fromSource(source, undefined);
1619
}
1720

18-
async function createGordonInstance(): Promise<ViewModelInstance> {
19-
const file = await loadFile(DATABINDING);
20-
const vm = file.viewModelByName('Person');
21-
expectDefined(vm);
22-
const instance = vm.createInstanceByName('Gordon');
23-
expectDefined(instance);
24-
return instance;
25-
}
26-
2721
describe('RiveFile ViewModel Access', () => {
2822
it('viewModelCount returns expected count', async () => {
2923
const file = await loadFile(DATABINDING);
@@ -136,7 +130,7 @@ describe('ViewModel Creation Variants', () => {
136130
expectDefined(vm);
137131

138132
// Legacy returns undefined, experimental returns an empty instance
139-
const instance = vm.createInstanceByIndex(100);
133+
vm.createInstanceByIndex(100);
140134
expect(true).toBe(true);
141135
});
142136

@@ -195,9 +189,9 @@ describe('List Properties', () => {
195189

196190
const names = ['Gordon', 'David', 'Tod', 'Erik', 'Adam'];
197191
for (let i = 0; i < names.length; i++) {
198-
const item = list.getInstanceAt(i);
192+
const item: ViewModelInstance = list.getInstanceAt(i)!;
199193
expectDefined(item);
200-
const nameProp = item.stringProperty('name');
194+
const nameProp: ViewModelStringProperty = item.stringProperty('name')!;
201195
expectDefined(nameProp);
202196
expect(nameProp.value).toBe(names[i]);
203197
}

0 commit comments

Comments
 (0)