Skip to content

fix: regenerate nitrogen files for nitro-modules 0.31.10#72

Merged
mfazekas merged 4 commits into
mainfrom
investigate-ci-errors
Dec 9, 2025
Merged

fix: regenerate nitrogen files for nitro-modules 0.31.10#72
mfazekas merged 4 commits into
mainfrom
investigate-ci-errors

Conversation

@mfazekas
Copy link
Copy Markdown
Collaborator

@mfazekas mfazekas commented Dec 9, 2025

PR #40 was merged with nitrogen files generated by nitro-modules@0.31.8.
PR #64 upgraded to nitro-modules@0.31.10 but didn't regenerate ViewModelImageProperty since it was developed before PR #40 merged.

Adds the missing #include <NitroModules/JNICallable.hpp> required by the newer nitrogen version.

PR #40 was merged with nitrogen files generated by nitro-modules@0.31.8.
PR #64 upgraded to nitro-modules@0.31.10 but was developed before PR #40
merged, so it didn't regenerate ViewModelImageProperty.

The new nitro-modules version requires JNICallable.hpp include.
The listeners property is MutableList<(Unit) -> Unit> but onChanged is () -> Unit.
Wrap in lambda to match the expected signature, same pattern as TriggerProperty.
PR #63 changed updateAsset from 3 args to 2 args (removed context) in
ReferencedAssetLoader but missed updating the call site in HybridRiveFile.
@mfazekas mfazekas requested a review from HayesGordon December 9, 2025 08:57
@mfazekas mfazekas merged commit 864f718 into main Dec 9, 2025
7 checks passed
@HayesGordon HayesGordon deleted the investigate-ci-errors branch December 9, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants