upgrade golangci-lint to v2.12.2 (#1299)

Author: bgentry

.github/workflows/ci.yaml

@@ -299,7 +299,7 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     env:
-      GOLANGCI_LINT_VERSION: v2.11.4
+      GOLANGCI_LINT_VERSION: v2.12.2
     permissions:
       contents: read
       # allow read access to pull request. Use with `only-new-issues` option.

.golangci.yaml

@@ -11,10 +11,15 @@ linters:
     - exhaustruct # checks that properties in structs are exhaustively defined; may be a good idea
     - testpackage # requires tests in test packages like `river_test`
 
+    # disabled because it's deprecated, and `default: all` already enables its
+    # replacement (`gomodguard_v2`)
+    - gomodguard
+
     # disabled because they're annoying/bad
     - cyclop # screams into the void at "cyclomatic complexity"
     - funcorder # very particular about where unexported functions can go, lots of churn.
     - funlen # screams when functions are more than 60 lines long; what are we even doing here guys
+    - goconst # wants repeated test strings and other obvious literals to be constants; lots of churn.
     - interfacebloat # we do in fact want >10 methods on the Adapter interface or wherever we see fit.
     - gocognit # yells that "cognitive complexity" is too high; why
     - gocyclo # ANOTHER "cyclomatic complexity" checker (see also "cyclop" and "gocyclo")

client.go

@@ -9,6 +9,7 @@ import (
 	"log/slog"
 	"os"
 	"regexp"
+	"slices"
 	"strings"
 	"sync"
 	"sync/atomic"
@@ -2011,9 +2012,9 @@ func (c *Client[TTx]) insertManyShared(
 	if len(jobInsertMiddleware) > 0 {
 		// Wrap middlewares in reverse order so the one defined first is wrapped
 		// as the outermost function and is first to receive the operation.
-		for i := len(jobInsertMiddleware) - 1; i >= 0; i-- {
-			middlewareItem := jobInsertMiddleware[i].(rivertype.JobInsertMiddleware) //nolint:forcetypeassert // capture the current middleware item
-			previousDoInner := doInner                                               // Capture the current doInner function
+		for _, v := range slices.Backward(jobInsertMiddleware) {
+			middlewareItem := v.(rivertype.JobInsertMiddleware) //nolint:forcetypeassert // capture the current middleware item
+			previousDoInner := doInner                          // Capture the current doInner function
 			doInner = func(ctx context.Context) ([]*rivertype.JobInsertResult, error) {
 				return middlewareItem.InsertMany(ctx, insertParams, previousDoInner)
 			}

internal/execution/execution.go

@@ -2,6 +2,7 @@ package execution
 
 import (
 	"context"
+	"slices"
 
 	"github.com/riverqueue/river/rivertype"
 )
@@ -22,17 +23,17 @@ func MiddlewareChain(globalMiddleware []rivertype.Middleware, workerMiddleware [
 
 	// Wrap middlewares in reverse order so the one defined first is wrapped
 	// as the outermost function and is first to receive the operation.
-	for i := len(globalMiddleware) - 1; i >= 0; i-- {
-		middlewareItem := globalMiddleware[i].(rivertype.WorkerMiddleware) //nolint:forcetypeassert // capture the current middleware item
-		previousDoInner := doInner                                         // capture the current doInner function
+	for _, v := range slices.Backward(globalMiddleware) {
+		middlewareItem := v.(rivertype.WorkerMiddleware) //nolint:forcetypeassert // capture the current middleware item
+		previousDoInner := doInner                       // capture the current doInner function
 		doInner = func(ctx context.Context) error {
 			return middlewareItem.Work(ctx, jobRow, previousDoInner)
 		}
 	}
 
-	for i := len(workerMiddleware) - 1; i >= 0; i-- {
-		middlewareItem := workerMiddleware[i] // capture the current middleware item
-		previousDoInner := doInner            // capture the current doInner function
+	for _, v := range slices.Backward(workerMiddleware) {
+		middlewareItem := v        // capture the current middleware item
+		previousDoInner := doInner // capture the current doInner function
 		doInner = func(ctx context.Context) error {
 			return middlewareItem.Work(ctx, jobRow, previousDoInner)
 		}

rivershared/circuitbreaker/circuit_breaker.go

@@ -1,6 +1,7 @@
 package circuitbreaker
 
 import (
+	"slices"
 	"time"
 
 	"github.com/riverqueue/river/rivershared/baseservice"
@@ -92,8 +93,8 @@ func (b *CircuitBreaker) Trip() bool {
 		horizonIndex = -1
 		now          = b.timeGenerator.Now()
 	)
-	for i := len(b.trips) - 1; i >= 0; i-- {
-		if b.trips[i].Before(now.Add(-b.opts.Window)) {
+	for i, v := range slices.Backward(b.trips) {
+		if v.Before(now.Add(-b.opts.Window)) {
 			horizonIndex = i
 			break
 		}

rivershared/structtag/struct_tag.go

@@ -83,7 +83,7 @@ func SortedFieldsWithTag(args rivertype.JobArgs, tagValue string) ([]string, err
 // don't cause a stack overflow.
 func sortedFieldsWithTagUncached(typ reflect.Type, tagValue string, path []string, typesSeen map[reflect.Type]struct{}) ([]string, error) {
 	// Handle pointer to struct
-	if typ.Kind() == reflect.Ptr {
+	if typ.Kind() == reflect.Pointer {
 		typ = typ.Elem()
 	}
 
@@ -188,7 +188,7 @@ func typeStructOrPointerToStruct(typ reflect.Type) bool {
 		return true
 	}
 
-	if typ.Kind() == reflect.Ptr && typ.Elem().Kind() == reflect.Struct {
+	if typ.Kind() == reflect.Pointer && typ.Elem().Kind() == reflect.Struct {
 		return true
 	}