Validation to detect duplicate step names in resumable jobs#1281
Open
brandur wants to merge 1 commit into
Open
Validation to detect duplicate step names in resumable jobs#1281brandur wants to merge 1 commit into
brandur wants to merge 1 commit into
Conversation
Follows up #1226 to tighten things up a little with a validation. If a user accidentally puts in duplicate step names, detect this problem and return an error. A duplicate step name represents a step that can never be resumed from, so it makes sense to find out about this sooner rather than later.
brandur
force-pushed
the
brandur-unique-step-names
branch
from
bc24956 to
39c4f1f
Compare
Contributor
|
@codex review |
bgentry
approved these changes
Jun 11, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
LGTM, up to you if you want to wait for Codex review ✌️
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #1226 to tighten things up a little with a validation. If a
user accidentally puts in duplicate step names, detect this problem and
return an error. A duplicate step name represents a step that can never
be resumed from, so it makes sense to find out about this sooner rather
than later.