Skip to content

Fix intermittent test: Test_Client_Stop/JobsInProgressCompletingPromptly #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Apr 28, 2025
Merged

Fix intermittent test: Test_Client_Stop/JobsInProgressCompletingPromptly #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,19 +1292,11 @@ func Test_Client_Stop(t *testing.T) {

client := runNewTestClient(ctx, t, newTestConfig(t, makeAwaitCallback(startedCh, doneCh)))

ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
defer cancel()

// enqueue job:
insertRes, err := client.Insert(ctx, callbackArgs{}, nil)
require.NoError(err)

var startedJobID int64
select {
case startedJobID = <-startedCh:
case <-time.After(1 * time.Second):
t.Fatal("timed out waiting for job to start")
}
startedJobID := riversharedtest.WaitOrTimeout(t, startedCh)
require.Equal(insertRes.Job.ID, startedJobID)

// Should not shut down immediately, not until jobs are given the signal to
Expand Down