Skip to content

Commit efd52ad

Browse files
Bump golang.org/x/crypto from 0.46.0 to 0.52.0 (#616)
* remove obsolete client table feature River v0.40 drops `river_client` and `river_client_queue`, leaving the features endpoint's probe permanently false on current schemas. The frontend never consults the flag, so retaining it only breaks the mounted endpoint response test and carries dead capability data. Remove the table probe and extension, delete its frontend feature plumbing, and trim tests that create or expect the retired table. Existing producer, sequence, and workflow capability checks remain. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Gentry <blakesgentry@gmail.com>
1 parent 495ccd0 commit efd52ad

11 files changed

Lines changed: 8 additions & 60 deletions

File tree

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ require (
3737
go.opentelemetry.io/otel v1.29.0 // indirect
3838
go.opentelemetry.io/otel/trace v1.29.0 // indirect
3939
go.uber.org/goleak v1.3.0 // indirect
40-
golang.org/x/crypto v0.46.0 // indirect
40+
golang.org/x/crypto v0.52.0 // indirect
4141
golang.org/x/sync v0.21.0 // indirect
42-
golang.org/x/sys v0.39.0 // indirect
42+
golang.org/x/sys v0.45.0 // indirect
4343
golang.org/x/text v0.38.0 // indirect
4444
gopkg.in/yaml.v3 v3.0.1 // indirect
4545
)

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ go.opentelemetry.io/otel/trace v1.29.0 h1:J/8ZNK4XgR7a21DZUAsbF8pZ5Jcw1VhACmnYt3
7575
go.opentelemetry.io/otel/trace v1.29.0/go.mod h1:eHl3w0sp3paPkYstJOmAimxhiFXPg+MMTlEh3nsQgWQ=
7676
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
7777
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
78-
golang.org/x/crypto v0.46.0 h1:cKRW/pmt1pKAfetfu+RCEvjvZkA9RimPbh7bhFjGVBU=
79-
golang.org/x/crypto v0.46.0/go.mod h1:Evb/oLKmMraqjZ2iQTwDwvCtJkczlDuTmdJXoZVzqU0=
78+
golang.org/x/crypto v0.52.0 h1:RMs7fP2rXdep0CftQlK8Uf+kibLm7qkCcradZWYz988=
79+
golang.org/x/crypto v0.52.0/go.mod h1:1QgfPxDqh0T2M/elOJtp9RvuR95kVjir0e6/BvEmGbc=
8080
golang.org/x/sync v0.21.0 h1:HLII4xRRTtCRkxYp4HNFF0Js/Og6q2i++KXbg0gHCwM=
8181
golang.org/x/sync v0.21.0/go.mod h1:9xrNwdLfx4jkKbNva9FpL6vEN7evnE43NNNJQ2LF3+0=
82-
golang.org/x/sys v0.39.0 h1:CvCKL8MeisomCi6qNZ+wbb0DN9E5AATixKsvNtMoMFk=
83-
golang.org/x/sys v0.39.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
82+
golang.org/x/sys v0.45.0 h1:dO4czNzziLiiXplLQgBCEpCvXQ3dnkn0SdaZSYdQ+FY=
83+
golang.org/x/sys v0.45.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
8484
golang.org/x/text v0.38.0 h1:sXmwo9DwP3OK9EZ7PqAdaooSGozfl/3a6/xJcbzPRhE=
8585
golang.org/x/text v0.38.0/go.mod h1:YXZt3QhHUKYT53r2lLKFIVi6Ao1jdzrTR/KQ09qyxF4=
8686
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

handler_api_endpoint_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,7 @@ func TestAPIHandlerFeaturesGet(t *testing.T) {
245245
// DisableSchemaSharing is required because we're making DB schema changes.
246246
endpoint, bundle := setupEndpointWithOpts(ctx, t, newFeaturesGetEndpoint, &riverdbtest.TestTxOpts{DisableSchemaSharing: true})
247247

248-
_, err := bundle.tx.Exec(ctx, `DROP TABLE IF EXISTS river_client CASCADE;`)
249-
require.NoError(t, err)
250-
_, err = bundle.tx.Exec(ctx, `DROP TABLE IF EXISTS river_job_sequence;`)
248+
_, err := bundle.tx.Exec(ctx, `DROP TABLE IF EXISTS river_job_sequence;`)
251249
require.NoError(t, err)
252250
_, err = bundle.tx.Exec(ctx, `DROP TABLE IF EXISTS river_producer;`)
253251
require.NoError(t, err)
@@ -270,9 +268,7 @@ func TestAPIHandlerFeaturesGet(t *testing.T) {
270268
// DisableSchemaSharing is required because we're making DB schema changes.
271269
endpoint, bundle := setupEndpointWithOpts(ctx, t, newFeaturesGetEndpoint, &riverdbtest.TestTxOpts{DisableSchemaSharing: true})
272270

273-
_, err := bundle.tx.Exec(ctx, `CREATE TABLE IF NOT EXISTS river_client (id SERIAL PRIMARY KEY);`)
274-
require.NoError(t, err)
275-
_, err = bundle.tx.Exec(ctx, `CREATE TABLE IF NOT EXISTS river_job_sequence (id SERIAL PRIMARY KEY);`)
271+
_, err := bundle.tx.Exec(ctx, `CREATE TABLE IF NOT EXISTS river_job_sequence (id SERIAL PRIMARY KEY);`)
276272
require.NoError(t, err)
277273
_, err = bundle.tx.Exec(ctx, `CREATE TABLE IF NOT EXISTS river_producer (id SERIAL PRIMARY KEY);`)
278274
require.NoError(t, err)

riverproui/endpoints.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,6 @@ func (e *endpoints[TTx]) Extensions(ctx context.Context) (map[string]bool, error
9090
}
9191
defer execTx.Rollback(ctx)
9292

93-
hasClientTable, err := execTx.TableExists(ctx, &riverdriver.TableExistsParams{
94-
Schema: schema,
95-
Table: "river_client",
96-
})
97-
if err != nil {
98-
return nil, err
99-
}
100-
10193
hasPeriodicJobTable, err := execTx.TableExists(ctx, &riverdriver.TableExistsParams{
10294
Schema: schema,
10395
Table: "river_periodic_job",
@@ -131,7 +123,6 @@ func (e *endpoints[TTx]) Extensions(ctx context.Context) (map[string]bool, error
131123
"durable_periodic_jobs": hasPeriodicJobTable,
132124
"producer_queries": true,
133125
"workflow_queries": hasWorkflowV2Tables,
134-
"has_client_table": hasClientTable,
135126
"has_producer_table": hasProducerTable,
136127
"has_sequence_table": hasSequenceTable,
137128
}, nil

riverproui/endpoints_test.go

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -95,36 +95,6 @@ func TestProEndpointsExtensions(t *testing.T) {
9595
})
9696
})
9797

98-
t.Run("ClientTableDetection", func(t *testing.T) { //nolint:dupl
99-
t.Parallel()
100-
101-
t.Run("NoClientTable", func(t *testing.T) {
102-
t.Parallel()
103-
104-
bundle := setup(ctx, t)
105-
106-
_, err := bundle.tx.Exec(ctx, `DROP TABLE IF EXISTS river_client CASCADE;`)
107-
require.NoError(t, err)
108-
109-
ext, err := bundle.endpoint.Extensions(ctx)
110-
require.NoError(t, err)
111-
require.False(t, ext["has_client_table"])
112-
})
113-
114-
t.Run("WithClientTable", func(t *testing.T) {
115-
t.Parallel()
116-
117-
bundle := setup(ctx, t)
118-
119-
_, err := bundle.tx.Exec(ctx, `CREATE TABLE IF NOT EXISTS river_client (id SERIAL PRIMARY KEY);`)
120-
require.NoError(t, err)
121-
122-
ext, err := bundle.endpoint.Extensions(ctx)
123-
require.NoError(t, err)
124-
require.True(t, ext["has_client_table"])
125-
})
126-
})
127-
12898
t.Run("ProducerTableDetection", func(t *testing.T) { //nolint:dupl
12999
t.Parallel()
130100

riverproui/pro_handler_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ func TestProMountedEndpointResponses(t *testing.T) {
186186
// Static flags always true; dynamic flags should also be true because pro migrations run for tests
187187
expectedExtensions := map[string]bool{
188188
"durable_periodic_jobs": true, // dynamic
189-
"has_client_table": true, // dynamic
190189
"has_producer_table": true, // dynamic
191190
"has_sequence_table": true, // dynamic
192191
"producer_queries": true, // static

src/App.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ const router = createRouter({
2929
basepath: getBasePath(),
3030
context: {
3131
features: {
32-
hasClientTable: false,
3332
hasProducerTable: false,
3433
producerQueries: false,
3534
workflowQueries: false,

src/components/WorkflowDetail.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ vi.mock("@components/workflow-diagram/WorkflowDiagram", () => ({
4242

4343
const features: Features = {
4444
durablePeriodicJobs: false,
45-
hasClientTable: false,
4645
hasProducerTable: true,
4746
hasSequenceTable: false,
4847
jobListHideArgsByDefault: false,

src/services/features.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ describe("apiFeaturesToFeatures", () => {
77
const apiFeatures = {
88
extensions: {
99
durable_periodic_jobs: true,
10-
has_client_table: true,
1110
has_producer_table: true,
1211
producer_queries: true,
1312
workflow_queries: true,
@@ -17,7 +16,6 @@ describe("apiFeaturesToFeatures", () => {
1716

1817
const expected = {
1918
durablePeriodicJobs: true,
20-
hasClientTable: true,
2119
hasProducerTable: true,
2220
hasSequenceTable: false,
2321
jobListHideArgsByDefault: true,
@@ -32,7 +30,6 @@ describe("apiFeaturesToFeatures", () => {
3230
const apiFeatures = {
3331
extensions: {
3432
durable_periodic_jobs: false,
35-
has_client_table: false,
3633
has_producer_table: false,
3734
producer_queries: false,
3835
workflow_queries: false,
@@ -42,7 +39,6 @@ describe("apiFeaturesToFeatures", () => {
4239

4340
const expected = {
4441
durablePeriodicJobs: false,
45-
hasClientTable: false,
4642
hasProducerTable: false,
4743
hasSequenceTable: false,
4844
jobListHideArgsByDefault: false,

src/services/features.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const KNOWN_EXTENSIONS = [
2020
"durable_periodic_jobs",
2121
"producer_queries",
2222
"workflow_queries",
23-
"has_client_table",
2423
"has_producer_table",
2524
"has_sequence_table",
2625
] as const;

0 commit comments

Comments
 (0)