Skip to content

Commit 4f7f8af

Browse files
committed
test(pi): enable real ACP bash coverage
1 parent 596ae5a commit 4f7f8af

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

docs-internal/registry-parity-worklist.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,14 @@ real e2e tests that prove Linux-parity behavior — not smoke tests.
683683
`2026-07-08T13-12-51-0700-item12-jq-check-types-final.log`;
684684
`2026-07-08T13-12-51-0700-item12-jq-cargo-fmt-check-final.log`.
685685
Rev: `slnmvuqz`.
686+
- **pi — DONE.** Enabled the existing real `createSession('pi')` headless
687+
suite in default core Vitest coverage and unskipped the upstream Pi SDK bash
688+
tool path. The suite proves initialization over the native sidecar
689+
transport plus real ACP write-tool and bash-tool flows inside the VM. Proof:
690+
`2026-07-08T14-37-00-0700-item12-cc-cache-restored-target-files.log`;
691+
`2026-07-08T14-37-00-0700-item12-sidecar-build-after-manual-cc-restore.log`;
692+
`2026-07-08T14-38-00-0700-item12-pi-headless-final-after-cc-restore.log`.
693+
Rev: `mzuuypsm`.
686694
- **Objective:** write real e2e tests proving each behaves like its Linux
687695
counterpart (jq processes real JSON, sed edits streams, tar round-trips archives,
688696
gzip round-trips, etc.); agents exercise the real ACP

packages/core/tests/pi-headless.test.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { resolve } from "node:path";
2-
import type { Fixture, ToolCall } from "@copilotkit/llmock";
3-
import { moduleAccessMounts } from "./helpers/node-modules-mount.js";
42
import common from "@agentos-software/common";
53
import pi from "@agentos-software/pi";
4+
import type { Fixture, ToolCall } from "@copilotkit/llmock";
65
import { describe, expect, test } from "vitest";
76
import type { AgentCapabilities, AgentInfo } from "../src/agent-os.js";
87
import { AgentOs } from "../src/agent-os.js";
@@ -11,6 +10,7 @@ import {
1110
startLlmock,
1211
stopLlmock,
1312
} from "./helpers/llmock-helper.js";
13+
import { moduleAccessMounts } from "./helpers/node-modules-mount.js";
1414

1515
const MODULE_ACCESS_CWD = resolve(import.meta.dirname, "..");
1616

@@ -206,15 +206,7 @@ describe("full createSession('pi') inside the VM", () => {
206206
}
207207
}, 120_000);
208208

209-
// Blocked on shell `>` redirect output being visible to `vm.readFile()`.
210-
// The vanilla Pi SDK bash backend spawns the shell directly and the redirect
211-
// runs inside the guest shell, but the written bytes do not reconcile to the
212-
// host read path yet. Before the adapter dropped its custom bash operations
213-
// override this case passed because the override routed the command through
214-
// the rpc-client `sh -c` path that the host can observe; the vanilla backend
215-
// surfaces the underlying runtime gap. Tracked in
216-
// ~/.agents/todo/agentos-runtime-fixes.md (shell-exec redirect visibility).
217-
test.skip("runs the real Pi SDK ACP flow end-to-end for bash tool calls", async () => {
209+
test("runs the real Pi SDK ACP flow end-to-end for bash tool calls", async () => {
218210
const fixtures = createToolFixtures(
219211
{
220212
name: "bash",

packages/core/vitest.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const SLOW_E2E_FILES = [
2020
"tests/batch-file-ops.test.ts",
2121
"tests/agentos-base-filesystem.test.ts",
2222
"tests/pi-sdk-boot-probe.test.ts",
23-
"tests/pi-headless.test.ts",
2423
"tests/pi-tool-llmock.test.ts",
2524
"tests/native-sidecar-process-permissions.test.ts",
2625
"tests/pi-extensions.test.ts",

0 commit comments

Comments
 (0)