fix(sqlite-native): restore kv error hook

Author: NathanFlurry

rivetkit-typescript/packages/rivetkit-native/src/database.rs

@@ -34,6 +34,10 @@ impl EnvoyKv {
 
 #[async_trait]
 impl SqliteKv for EnvoyKv {
+	fn on_error(&self, actor_id: &str, error: &SqliteKvError) {
+		tracing::error!(%actor_id, %error, "native sqlite kv operation failed");
+	}
+
 	async fn on_open(&self, _actor_id: &str) -> Result<(), SqliteKvError> {
 		Ok(())
 	}

rivetkit-typescript/packages/sqlite-native/src/sqlite_kv.rs

@@ -68,6 +68,10 @@ pub struct KvGetResult {
 /// at a higher level.
 #[async_trait]
 pub trait SqliteKv: Send + Sync {
+	/// Called when a KV operation fails inside a VFS callback before the
+	/// original error is collapsed into a generic SQLite IO error code.
+	fn on_error(&self, _actor_id: &str, _error: &SqliteKvError) {}
+
 	/// Called when an actor's database is opened.
 	async fn on_open(&self, _actor_id: &str) -> Result<(), SqliteKvError> {
 		Ok(())

rivetkit-typescript/packages/sqlite-native/src/vfs.rs

@@ -14,7 +14,7 @@ use libsqlite3_sys::*;
 use tokio::runtime::Handle;
 
 use crate::kv;
-use crate::sqlite_kv::{KvGetResult, SqliteKv};
+use crate::sqlite_kv::{KvGetResult, SqliteKv, SqliteKvError};
 
 // MARK: Panic Guard
 
@@ -159,6 +159,11 @@ struct VfsContext {
 }
 
 impl VfsContext {
+	fn report_kv_error(&self, err: SqliteKvError) -> String {
+		self.kv.on_error(&self.actor_id, &err);
+		err.to_string()
+	}
+
 	fn resolve_file_tag(&self, path: &str) -> Option<u8> {
 		if path == self.main_file_name {
 			return Some(kv::FILE_TAG_MAIN);
@@ -187,7 +192,7 @@ impl VfsContext {
 		let result = self
 			.rt_handle
 			.block_on(self.kv.batch_get(&self.actor_id, keys))
-			.map_err(|e| e.to_string());
+			.map_err(|err| self.report_kv_error(err));
 		let elapsed = start.elapsed();
 		if trace_sql {
 			tracing::trace!(
@@ -215,7 +220,7 @@ impl VfsContext {
 		let result = self
 			.rt_handle
 			.block_on(self.kv.batch_put(&self.actor_id, keys, values))
-			.map_err(|e| e.to_string());
+			.map_err(|err| self.report_kv_error(err));
 		let elapsed = start.elapsed();
 		if trace_sql {
 			tracing::trace!(
@@ -243,7 +248,7 @@ impl VfsContext {
 		let result = self
 			.rt_handle
 			.block_on(self.kv.batch_delete(&self.actor_id, keys))
-			.map_err(|e| e.to_string());
+			.map_err(|err| self.report_kv_error(err));
 		let elapsed = start.elapsed();
 		if trace_sql {
 			tracing::trace!(
@@ -266,7 +271,7 @@ impl VfsContext {
 		let result = self
 			.rt_handle
 			.block_on(self.kv.delete_range(&self.actor_id, start, end))
-			.map_err(|e| e.to_string());
+			.map_err(|err| self.report_kv_error(err));
 		let elapsed = start_time.elapsed();
 		if sql_trace_enabled() {
 			tracing::trace!(