Skip to content

Commit 8490d0e

Browse files
committed
fix(pegboard): isolate runner config dc lookup failures
1 parent 236286b commit 8490d0e

1 file changed

Lines changed: 17 additions & 5 deletions

File tree

engine/packages/pegboard/src/ops/runner/list_runner_config_enabled_dcs.rs

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use anyhow::Result;
22
use epoxy_protocol::generated::v2::CachingBehavior;
3-
use futures_util::{StreamExt, TryStreamExt};
3+
use futures_util::StreamExt;
44
use gas::prelude::*;
55

66
use crate::keys;
@@ -74,12 +74,24 @@ async fn list_runner_config_enabled_dcs_inner(
7474
target_replicas: None,
7575
save_empty: true,
7676
})
77-
.await?;
77+
.await;
7878

79-
Ok(res.value.map(|_| dc.datacenter_label))
79+
match res {
80+
Ok(res) => res.value.map(|_| dc.datacenter_label),
81+
Err(err) => {
82+
tracing::warn!(
83+
?err,
84+
namespace_id=?input.namespace_id,
85+
runner_name=%input.runner_name,
86+
dc_label=dc.datacenter_label,
87+
"failed to read runner config from dc"
88+
);
89+
None
90+
}
91+
}
8092
})
8193
.buffer_unordered(512)
82-
.try_filter_map(|x| std::future::ready(Ok(x)))
83-
.try_collect::<Vec<_>>()
94+
.filter_map(std::future::ready)
95+
.collect::<Vec<_>>()
8496
.await
8597
}

0 commit comments

Comments
 (0)